Closed
Bug 1499813
Opened 6 years ago
Closed 6 years ago
ReadableStream cleanup
Categories
(Core :: JavaScript Engine, enhancement, P1)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
firefox65 | --- | fixed |
People
(Reporter: jorendorff, Assigned: jorendorff)
References
(Blocks 1 open bug)
Details
Attachments
(10 files)
46 bytes,
text/x-phabricator-request
|
Details | Review | |
46 bytes,
text/x-phabricator-request
|
Details | Review | |
46 bytes,
text/x-phabricator-request
|
Details | Review | |
46 bytes,
text/x-phabricator-request
|
Details | Review | |
46 bytes,
text/x-phabricator-request
|
Details | Review | |
46 bytes,
text/x-phabricator-request
|
Details | Review | |
46 bytes,
text/x-phabricator-request
|
Details | Review | |
46 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review |
First steps to make this code easier to work with, as requested by tcampbell. 1. Rename arguments and locals that hold unwrapped pointers (which thus may not be same-compartment with cx). 2. Arguments to methods should be unwrapped and same-compartment with cx; where that's not possible, document it and give the method a weird name or make it a non-member function.
Assignee | ||
Updated•6 years ago
|
Blocks: streams-enable
Assignee | ||
Updated•6 years ago
|
Priority: -- → P1
Assignee | ||
Comment 1•6 years ago
|
||
Assignee | ||
Comment 2•6 years ago
|
||
Depends on D9834
Assignee | ||
Comment 3•6 years ago
|
||
Depends on D9835
Assignee | ||
Comment 4•6 years ago
|
||
Depends on D9836
Assignee | ||
Comment 5•6 years ago
|
||
Depends on D9837
Assignee | ||
Comment 6•6 years ago
|
||
Depends on D9839
Assignee | ||
Comment 7•6 years ago
|
||
Depends on D9840
Assignee | ||
Comment 8•6 years ago
|
||
Depends on D9841
Assignee | ||
Comment 9•6 years ago
|
||
Updated•6 years ago
|
Assignee: nobody → jorendorff
Assignee | ||
Updated•6 years ago
|
Blocks: streams-meta
Assignee | ||
Comment 10•6 years ago
|
||
Depends on D10086
Assignee | ||
Comment 11•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f47eb2d79f8fde7acf778d09acd844df0bace869
Assignee | ||
Updated•6 years ago
|
Keywords: leave-open
Comment 12•6 years ago
|
||
Pushed by jorendorff@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6d2f90634a78 Part 1: Remove an unused variable. r=tcampbell https://hg.mozilla.org/integration/autoland/rev/89ebcbf1fd6f Part 2: JSObject::unwrapAs<T>() and canUnwrapAs<T>() methods. r=tcampbell https://hg.mozilla.org/integration/autoland/rev/53fdcf1bb3f6 Part 3: Replace some ToUnwrapped signatures with new js::UnwrapThis<T>() template. r=tcampbell https://hg.mozilla.org/integration/autoland/rev/a6ce48743101 Part 4: Remove _impl methods, replace with unwrapping. r=tcampbell https://hg.mozilla.org/integration/autoland/rev/be8a33abed1a Part 5: Update Streams spec section numbers in comments. r=tcampbell https://hg.mozilla.org/integration/autoland/rev/c5c23b4d15af Part 6: New template UnwrapSlot<T>() for reading a "statically typed" slot. Remove TeeState::stream() in favor of UnwrapSlot. r=tcampbell https://hg.mozilla.org/integration/autoland/rev/96691182d92e Part 7: Change ReaderFromStream to use UnwrapSlot. r=tcampbell https://hg.mozilla.org/integration/autoland/rev/a2ba7ef15785 Part 8: Change StreamFromReader to use UnwrapSlot. r=tcampbell
Assignee | ||
Comment 13•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=213d0fd374bb6ddec0be8b85b05e4b11f91094fc
Comment 14•6 years ago
|
||
Pushed by jorendorff@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/06b1ba7f6a7a Part 9: Apply the `unwrapped` naming convention to algorithms in Streams spec section 3.8. r=tcampbell https://hg.mozilla.org/integration/autoland/rev/087715c3ea18 Part 10: Change SetNewList return type to bool. r=tcampbell
Comment 15•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/6d2f90634a78 https://hg.mozilla.org/mozilla-central/rev/89ebcbf1fd6f https://hg.mozilla.org/mozilla-central/rev/53fdcf1bb3f6 https://hg.mozilla.org/mozilla-central/rev/a6ce48743101 https://hg.mozilla.org/mozilla-central/rev/be8a33abed1a https://hg.mozilla.org/mozilla-central/rev/c5c23b4d15af https://hg.mozilla.org/mozilla-central/rev/96691182d92e https://hg.mozilla.org/mozilla-central/rev/a2ba7ef15785
Comment 16•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/06b1ba7f6a7a https://hg.mozilla.org/mozilla-central/rev/087715c3ea18
Assignee | ||
Updated•6 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•