Closed Bug 1499813 Opened 4 years ago Closed 4 years ago

ReadableStream cleanup

Categories

(Core :: JavaScript Engine, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
Tracking Status
firefox65 --- fixed

People

(Reporter: jorendorff, Assigned: jorendorff)

References

(Blocks 1 open bug)

Details

Attachments

(10 files)

46 bytes, text/x-phabricator-request
Details | Review
46 bytes, text/x-phabricator-request
Details | Review
46 bytes, text/x-phabricator-request
Details | Review
46 bytes, text/x-phabricator-request
Details | Review
46 bytes, text/x-phabricator-request
Details | Review
46 bytes, text/x-phabricator-request
Details | Review
46 bytes, text/x-phabricator-request
Details | Review
46 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
First steps to make this code easier to work with, as requested by tcampbell.

1. Rename arguments and locals that hold unwrapped pointers (which thus may not be same-compartment with cx).

2. Arguments to methods should be unwrapped and same-compartment with cx; where that's not possible, document it and give the method a weird name or make it a non-member function.
Depends on: 1501387
Priority: -- → P1
Assignee: nobody → jorendorff
Blocks: streams-meta
Keywords: leave-open
Pushed by jorendorff@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6d2f90634a78
Part 1: Remove an unused variable. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/89ebcbf1fd6f
Part 2: JSObject::unwrapAs<T>() and canUnwrapAs<T>() methods. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/53fdcf1bb3f6
Part 3: Replace some ToUnwrapped signatures with new js::UnwrapThis<T>() template. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/a6ce48743101
Part 4: Remove _impl methods, replace with unwrapping. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/be8a33abed1a
Part 5: Update Streams spec section numbers in comments. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/c5c23b4d15af
Part 6: New template UnwrapSlot<T>() for reading a "statically typed" slot. Remove TeeState::stream() in favor of UnwrapSlot. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/96691182d92e
Part 7: Change ReaderFromStream to use UnwrapSlot. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/a2ba7ef15785
Part 8: Change StreamFromReader to use UnwrapSlot. r=tcampbell
Pushed by jorendorff@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/06b1ba7f6a7a
Part 9: Apply the `unwrapped` naming convention to algorithms in Streams spec section 3.8. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/087715c3ea18
Part 10: Change SetNewList return type to bool. r=tcampbell
Status: NEW → RESOLVED
Closed: 4 years ago
Keywords: leave-open
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.