Closed Bug 1499860 Opened 6 years ago Closed 6 years ago

Attachment filtering fails in Gloda search

Categories

(MailNews Core :: Database, defect)

defect
Not set
normal

Tracking

(thunderbird_esr6063+ fixed, thunderbird63 wontfix, thunderbird64 fixed)

RESOLVED FIXED
Thunderbird 64.0
Tracking Status
thunderbird_esr60 63+ fixed
thunderbird63 --- wontfix
thunderbird64 --- fixed

People

(Reporter: ldearquer, Assigned: jorgk-bmo)

References

Details

Attachments

(2 files, 1 obsolete file)

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:62.0) Gecko/20100101 Firefox/62.0

Steps to reproduce:

Start a new search (search box on toolbar, NOT quick filter)
On the "Filters" area, click on Attachments to filter only emails with attachments


Actual results:

No filtering happens. Only a drop-down box appears with "Any kind" on it
Selecting other items in the drop-down box yields "No messages match your search". Even trying "Any kind" again.
After running Thunderbird from terminal, this messages comes up when clicking on Attachments:

JavaScript error: resource:///modules/gloda/noun_mimetype.js, line 321: TypeError: aArguments is undefined

Linux Mint 19. Version from repository


Expected results:

Seeing only the emails with attachments on the filter result
Summary: Attachment filtering fails in search → Attachment filtering fails in Gloda search
Attached patch 1499860-gloda.patch (obsolete) — Splinter Review
Does this look reasonable? I didn't try the test case.
Assignee: nobody → jorgk
Status: UNCONFIRMED → NEW
Ever confirmed: true
Attachment #9018163 - Flags: review?(geoff)
Attachment #9018163 - Flags: review?(acelists)
You want !aArguments || aArguments.length == 0, surely?
That was nonsense :-(
Attachment #9018163 - Attachment is obsolete: true
Attachment #9018163 - Flags: review?(geoff)
Attachment #9018163 - Flags: review?(acelists)
Attachment #9018165 - Flags: review?(geoff)
Attachment #9018165 - Flags: review?(acelists)
Comment on attachment 9018165 [details] [diff] [review]
1499860-gloda.patch

Review of attachment 9018165 [details] [diff] [review]:
-----------------------------------------------------------------

Fine by me, but have you checked it fixes the problem?
Attachment #9018165 - Flags: review?(geoff)
Attachment #9018165 - Flags: review?(acelists)
Attachment #9018165 - Flags: review+
Not yet. Will do.
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/6c017363106f
fix Gloda attachment filtering, don't access length of 'undefined' in Gloda Category() function. r=darktrojan DONTBUILD
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
It worked.
Target Milestone: --- → Thunderbird 64.0
Attachment #9018165 - Flags: approval-comm-esr60+
Attachment #9018165 - Flags: approval-comm-beta+
Looking at the release calendar, I understood Thunderbird follows ESR release of firefox. Does this mean the fix won't be available until Q4 2019 on distributions (when 68 is released)?
Is it possible to include the fix be included in 60.3?
Of course.
Thanks!
(doesn't belong in untriaged)
Component: Untriaged → Database
Product: Thunderbird → MailNews Core

No filtering happens in 74.0b1. If select any other option documents, pdf etc and click somewhere else, from me buttons & to me buttons, total attachment option disappear as seen screen shot.

Attached image attcahment filter.jpg

Step to produce :
step 1 search some key word.
step 2 change filter attachment to some other option
step3 click attachment collapses attachment
step4 click again attachment. it will disappear.

for me, other than "any kind" yield 0 results.

Please file a new bug. No one will pay attention to new comments in a resolved bug.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: