Closed
Bug 1499860
Opened 6 years ago
Closed 6 years ago
Attachment filtering fails in Gloda search
Categories
(MailNews Core :: Database, defect)
Tracking
(thunderbird_esr6063+ fixed, thunderbird63 wontfix, thunderbird64 fixed)
RESOLVED
FIXED
Thunderbird 64.0
People
(Reporter: ldearquer, Assigned: jorgk-bmo)
References
Details
Attachments
(2 files, 1 obsolete file)
1.14 KB,
patch
|
darktrojan
:
review+
jorgk-bmo
:
approval-comm-beta+
jorgk-bmo
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
11.83 KB,
image/jpeg
|
Details |
User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:62.0) Gecko/20100101 Firefox/62.0 Steps to reproduce: Start a new search (search box on toolbar, NOT quick filter) On the "Filters" area, click on Attachments to filter only emails with attachments Actual results: No filtering happens. Only a drop-down box appears with "Any kind" on it Selecting other items in the drop-down box yields "No messages match your search". Even trying "Any kind" again. After running Thunderbird from terminal, this messages comes up when clicking on Attachments: JavaScript error: resource:///modules/gloda/noun_mimetype.js, line 321: TypeError: aArguments is undefined Linux Mint 19. Version from repository Expected results: Seeing only the emails with attachments on the filter result
Assignee | ||
Updated•6 years ago
|
Summary: Attachment filtering fails in search → Attachment filtering fails in Gloda search
Assignee | ||
Comment 1•6 years ago
|
||
Does this look reasonable? I didn't try the test case.
Assignee: nobody → jorgk
Status: UNCONFIRMED → NEW
Ever confirmed: true
Attachment #9018163 -
Flags: review?(geoff)
Attachment #9018163 -
Flags: review?(acelists)
Comment 2•6 years ago
|
||
You want !aArguments || aArguments.length == 0, surely?
Assignee | ||
Comment 3•6 years ago
|
||
That was nonsense :-(
Attachment #9018163 -
Attachment is obsolete: true
Attachment #9018163 -
Flags: review?(geoff)
Attachment #9018163 -
Flags: review?(acelists)
Attachment #9018165 -
Flags: review?(geoff)
Attachment #9018165 -
Flags: review?(acelists)
Comment 4•6 years ago
|
||
Comment on attachment 9018165 [details] [diff] [review] 1499860-gloda.patch Review of attachment 9018165 [details] [diff] [review]: ----------------------------------------------------------------- Fine by me, but have you checked it fixes the problem?
Attachment #9018165 -
Flags: review?(geoff)
Attachment #9018165 -
Flags: review?(acelists)
Attachment #9018165 -
Flags: review+
Assignee | ||
Comment 5•6 years ago
|
||
Not yet. Will do.
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/6c017363106f fix Gloda attachment filtering, don't access length of 'undefined' in Gloda Category() function. r=darktrojan DONTBUILD
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•6 years ago
|
Attachment #9018165 -
Flags: approval-comm-esr60+
Attachment #9018165 -
Flags: approval-comm-beta+
Assignee | ||
Comment 8•6 years ago
|
||
TB 63 beta 2: https://hg.mozilla.org/releases/comm-beta/rev/9ce6347cab62c88c5890d00e901bc3a959487d33
status-thunderbird63:
--- → fixed
status-thunderbird64:
--- → fixed
status-thunderbird_esr60:
--- → affected
Looking at the release calendar, I understood Thunderbird follows ESR release of firefox. Does this mean the fix won't be available until Q4 2019 on distributions (when 68 is released)? Is it possible to include the fix be included in 60.3?
Assignee | ||
Comment 10•6 years ago
|
||
Of course.
Reporter | ||
Comment 11•6 years ago
|
||
Thanks!
Comment 12•6 years ago
|
||
(doesn't belong in untriaged)
Component: Untriaged → Database
Product: Thunderbird → MailNews Core
Assignee | ||
Comment 13•6 years ago
|
||
TB 60.3 ESR: https://hg.mozilla.org/releases/comm-esr60/rev/f2dcb413cb3119b86e51f091e86e139e7843c286
Assignee | ||
Updated•6 years ago
|
Comment 15•4 years ago
|
||
No filtering happens in 74.0b1. If select any other option documents, pdf etc and click somewhere else, from me buttons & to me buttons, total attachment option disappear as seen screen shot.
Comment 16•4 years ago
|
||
Comment 17•4 years ago
|
||
Step to produce :
step 1 search some key word.
step 2 change filter attachment to some other option
step3 click attachment collapses attachment
step4 click again attachment. it will disappear.
Comment 18•4 years ago
|
||
for me, other than "any kind" yield 0 results.
Assignee | ||
Comment 19•4 years ago
|
||
Please file a new bug. No one will pay attention to new comments in a resolved bug.
You need to log in
before you can comment on or make changes to this bug.
Description
•