Closed Bug 1499864 Opened Last year Closed Last year

Fix -Wdelete-non-virtual-dtor in toolkit/system/windowsDHCPClient/WindowsNetworkFunctionsWrapper.cpp

Categories

(Core :: Networking: HTTP, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: jgilbert, Assigned: jgilbert)

Details

(Whiteboard: [necko-triaged])

Attachments

(1 file)

> toolkit/system/windowsDHCPClient/WindowsNetworkFunctionsWrapper.cpp:19:1 [-Wdelete-non-virtual-dtor] delete called on non-final 'mozilla::toolkit::system::windowsDHCPClient::WindowsNetworkFunctionsWrapper' that has virtual functions but non-virtual destructor

Seems like this should just be a virtual dtor.
Also delete declaration of an unused var.
Both of these are compile warnings on win64 clang-cl.

MozReview-Commit-ID: aOBmtxgpz6
Priority: -- → P3
Whiteboard: [necko-triaged]
Pushed by jgilbert@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9e0a42364ef5
WindowsNetworkFunctionsWrapper's dtor should be virtual. r=bagder
https://hg.mozilla.org/mozilla-central/rev/9e0a42364ef5
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.