Closed Bug 1499916 Opened 11 months ago Closed 11 months ago

Style for URLbar in webpage content tabs

Categories

(Thunderbird :: Theme, enhancement)

enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 64.0

People

(Reporter: BenB, Assigned: Paenglab)

References

Details

Attachments

(2 files)

Thunderbird can show webpages in a tab, called "content tabs".
With bug 1497527, they are now showing the URL, so that the user has a trust anchor.

But the URLbar needs to be styled (see bug 1497527 comment 14).
This makes the toolbar styleable and the text inside the textbox selectable (but it's not a input field only copy works).
Attachment #9018257 - Flags: review?(jorgk)
What did Neil mean with bug 1497527 comment #22, quote:
  Ugh, if only you'd found a better solution back in bug 1230250 comment 6...
Before I start (tonight), what does "toolbar" mean:
  This makes the toolbar styleable ...
  Style the toolbar and URLbar in webpage content tabs ...

I understand the URLbar is the horizontal area/strip that has the box with the URL and the security indicator. Have I missed the toolbar? And what is .themeableSearchBox for?
(In reply to Jorg K (GMT+2) from comment #2)
> What did Neil mean with bug 1497527 comment #22, quote:
>   Ugh, if only you'd found a better solution back in bug 1230250 comment 6...

I've added the themeableSearchBox class. I'll look if I can change the other IDs into this class to make the CSS simpler.

(In reply to Jorg K (GMT+2) from comment #3)
> Before I start (tonight), what does "toolbar" mean:
>   This makes the toolbar styleable ...
>   Style the toolbar and URLbar in webpage content tabs ...
> 
> I understand the URLbar is the horizontal area/strip that has the box with
> the URL and the security indicator. Have I missed the toolbar? And what is
> .themeableSearchBox for?

The content toolbox/bar wasn't fully styleable through LW-themes etc. because they are not used until now. Now it looks always looks the main toolbar. I also applied the toolbarbutton colours, so if someone wants to add a toolbarbutton it looks like the ones of the main toolbar.
Attached image 1499916.png
This works OK, but I'm really confused by the nomenclature:

(In reply to Richard Marti (:Paenglab) from comment #4)
> The content toolbox/bar wasn't fully styleable through LW-themes etc.
> because they are not used until now. Now it looks always looks the main
> toolbar. I also applied the toolbarbutton colours, so if someone wants to
> add a toolbarbutton it looks like the ones of the main toolbar.

What do you call content toolbox/bar? It's styled like the main toolbar (not visible here) and the active tab.

And what do you call the URLbar?

So the toolbar is the big horizontal bar from left to right and the URLbar is the box with the URL inside?
(In reply to Jorg K (GMT+2) from comment #5)
> And what do you call the URLbar?

Ben called it the URLbar

> So the toolbar is the big horizontal bar from left to right and the URLbar
> is the box with the URL inside?

Yep, both is correct.
> what do you call the URLbar?

I call the box and toolbar that shows the URL of the current webpage a "URLbar".
Comment on attachment 9018257 [details] [diff] [review]
1499916-contentTabStyling.patch

OK, let's call the thing that goes across the screen the URLbar and the box inside the URLbox. Referring to it as a toolbar seems a little confusing. It appears to be mandatory and doesn't show up under "View > Toolbars".
Attachment #9018257 - Flags: review?(jorgk) → review+
> let's call the thing that goes across the screen the URLbar and the box inside the URLbox

Makes sense. Sorry for the confusion.
When you look at the messenger.xul part in this patch, you see <toolbox> and <toolbar> and the classes are contentTabToolbox and contentTabToolbar. That's why I refer to toolbox/toolbar.
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/9d49d405053c
Style URLbar/box in webpage content tabs like the main toolbar when LW-themes are applied. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: 11 months ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 64.0
You need to log in before you can comment on or make changes to this bug.