Polish Network panel filter buttons UI

RESOLVED FIXED in Firefox 65

Status

P3
normal
RESOLVED FIXED
5 months ago
2 months ago

People

(Reporter: Honza, Assigned: lba_2, Mentored)

Tracking

({good-first-bug})

unspecified
Firefox 65
good-first-bug

Firefox Tracking Flags

(firefox65 fixed)

Details

(Whiteboard: good-first-bug, [good first verify] [testday20190111])

Attachments

(3 attachments, 2 obsolete attachments)

Posted image image.png
Network monitor filter buttons (see attached screenshot) use grey background when selected and almost the same grey background when hovered by mouse -> confusing.

Also, Console filter buttons use blue background (see attached screenshot), which might be what we want for the Network panel too? It would be great if the design is unified across these panels.

Honza
@Matt, what do you think. Should the Network panel just use the same styling as the Console panel?

Honza
Flags: needinfo?(mcroud)
Priority: -- → P3

Comment 2

5 months ago
Absolutely, this would make sense both from a consistency point of view and from a Photon devtools documentation point of view.
Additionally, this does no occur in dark mode.
Flags: needinfo?(mcroud)
Mentor: odvarko
Keywords: good-first-bug
Whiteboard: good-first-bug
(Assignee)

Comment 3

5 months ago
@Honza, 
I was wandering if this is something I can try to work on. Since I don't need to wait for any UI decision as it is suggested to just copy the pattern used in console tab.

if yes, can you please advise how to get the filter buttons displayed in the Console? I don't see them. Thanks.
Lenka
(Assignee)

Comment 4

5 months ago
@Honza, I already found the way to turn the filter buttons on in Console :-)
(Assignee)

Comment 5

5 months ago
@Honza, can I be assigned to work on this one?
thanks,
Lenka
Flags: needinfo?(odvarko)
Assigned to you, thanks for the help!

Honza
Assignee: nobody → lba_2
Status: NEW → ASSIGNED
Flags: needinfo?(odvarko)
(In reply to lba_2 from comment #3)
> I was wandering if this is something I can try to work on. Since I don't
> need to wait for any UI decision as it is suggested to just copy the pattern
> used in console tab.
Yes

> if yes, can you please advise how to get the filter buttons displayed in the
> Console? I don't see them. Thanks.
Use Browser Toolbox to inspect the Console panel and figure out what CSS rules and properties are used
https://developer.mozilla.org/en-US/docs/Tools/Browser_Toolbox

Honza
(Assignee)

Comment 8

5 months ago
@Honza,
Please have a look here:
https://searchfox.org/mozilla-central/source/devtools/client/netmonitor/src/assets/styles/Toolbar.css#17

Removing lines 17-21 from Toolbar.css fixes the issue and the behavior in light-theme is the same as in dark and same as in Console. 

However, we don't know who put it there and why. This comment is not found anywhere else in the codebase and to me it seems that this is not a place to code color directly as all the other colors are done through variables. Also, this code sets a color for light-theme only.

EVen the lines 12-15 don't seem to be used when I look at used style in Browser Toolbox.

So there are several things I can do here:
1. completely remove lines 17-21 (I would vote for this one)
2. just comment out the lines 17-21 (for possible future???)
3. just remove the class .devtools-button.checked from the styling in line 18
4. remove both parts for the code - lines 12-15 and 17-21

Please advise. Thanks,
Lenka
Flags: needinfo?(odvarko)
(In reply to lba_2 from comment #8)
> @Honza,
> Please have a look here:
> https://searchfox.org/mozilla-central/source/devtools/client/netmonitor/src/
> assets/styles/Toolbar.css#17
> 
> Removing lines 17-21 from Toolbar.css fixes the issue and the behavior in
> light-theme is the same as in dark and same as in Console. 
> 
> However, we don't know who put it there and why. This comment is not found
Mozilla source is mirrored on GitHub and you can use 'Blame' to see who introduced
the changes. For this specific place:
https://github.com/mozilla/gecko-dev/commit/82e30fd3aa163cbf7d1843176e68cf43f4994e13

> anywhere else in the codebase and to me it seems that this is not a place to
> code color directly as all the other colors are done through variables.
> Also, this code sets a color for light-theme only.
Yeah, we can fix it as part of this bug.


> EVen the lines 12-15 don't seem to be used when I look at used style in
> Browser Toolbox.
> 
> So there are several things I can do here:
> 1. completely remove lines 17-21 (I would vote for this one)
Agree

> 2. just comment out the lines 17-21 (for possible future???)
> 3. just remove the class .devtools-button.checked from the styling in line 18
> 4. remove both parts for the code - lines 12-15 and 17-21

Thanks!

Honza
Flags: needinfo?(odvarko)
(Assignee)

Comment 10

5 months ago
I have just removed the "special case" styling from Toolbar.css and now the styles are inherited from theme (light/dark). Same behavior like in Console Filter buttons.
Attachment #9019971 - Flags: review?(odvarko)
Comment on attachment 9019971 [details] [diff] [review]
Restore background color of Filter buttons in Network Monitor so it is the same as in Console

Review of attachment 9019971 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, thanks for the patch!

Honza
Attachment #9019971 - Flags: review?(odvarko) → review+
Comment on attachment 9019971 [details] [diff] [review]
Restore background color of Filter buttons in Network Monitor so it is the same as in Console

Ah, one more thing. You need to put commit message into the patch.

See more here:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch#Creating_a_patch

Here is an example how the commit message looks like in the patch (coming from the other bug you are working on)

# HG changeset patch
# User Jan Odvarko <odvarko@gmail.com>
# Date 1540477805 -7200
#      Thu Oct 25 16:30:05 2018 +0200
# Node ID 00bf95f9423c225fa16fd94c7fe19450462d741b
# Parent  3cc04ee79005058d817daf66da7963dfac3f0a3a
Bug 1499042 - Fix learn more links in the Network panel; r=Honza


Honza
Attachment #9019971 - Flags: review+
Flags: needinfo?(lba_2)
(Assignee)

Comment 13

5 months ago
Somehow, I wasn't able to see the commit message in the patch.
I ran: hg commit --amend
the Emacs editor opened

This is what I saved:
Bug1500018 - Polish Network panel filter buttons UI; r=Honza


HG: Enter commit message.  Lines beginning with 'HG:' are removed.
HG: Leave message empty to abort commit.
HG: --
HG: user: lenpel <lba_2@yahoo.com>
HG: branch 'default'
HG: changed devtools/client/netmonitor/src/assets/styles/Toolbar.css

However, the change wasn't taken into the patch itself. Any hints please?
Thanks,
Lenka

p.s. How do I create a commit message correctly the first time when creating a patch? (I created patch by using hg diff>mypatch.patch)
Flags: needinfo?(lba_2) → needinfo?(odvarko)
(In reply to lba_2 from comment #13)
> p.s. How do I create a commit message correctly the first time when creating
> a patch? (I created patch by using hg diff>mypatch.patch)

You should do:

# export the latest commit 
hg export tip > my-patch.patch

# export the latest patch in HG queues
hg export qtip > my-patch.patch

# export specific revision
hg export 443077:5a123d345104 > my-patch.patch

You can use:
hg log 

.. to see commits and revisions

Honza
Flags: needinfo?(odvarko)
(Assignee)

Comment 15

5 months ago
I am getting 'unknown revision 443077 so no progress here...
I think I am messing things up by working on two different patches here.
I am going to do some reading about hg and the whole patch process because it's getting confusing. Thanks.
Lenka
(Assignee)

Comment 16

5 months ago
Posted patch toolbar4.patch (obsolete) — Splinter Review
Restore background color of Filter buttons in Network Monitor so it is the same as in Console. Added commit message to the patch.
Attachment #9019971 - Attachment is obsolete: true
Attachment #9020939 - Flags: review?(odvarko)
Comment on attachment 9020939 [details] [diff] [review]
toolbar4.patch

Review of attachment 9020939 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, thanks!

Honza
Attachment #9020939 - Flags: review?(odvarko) → review+
Keywords: checkin-needed

Comment 18

5 months ago
Pushed by ebalazs@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a9d64f4b6a3f
Polish Network panel filter buttons UI; r=Honza
Keywords: checkin-needed
Backed out changeset a9d64f4b6a3f (bug 1500018) for devtools failures at browser/base/content/test/static/browser_parsable_css.js

Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/7d26eab2282239e87a9709e1b59beea7fb515e95

Failure push: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=a9d64f4b6a3fac50c440cfc4d07d81433550ce26

Failure log; https://treeherder.mozilla.org/logviewer.html#?job_id=208659759&repo=mozilla-inbound&lineNumber=1386

TEST-START | browser/base/content/test/static/browser_parsable_css.js
09:06:07     INFO - TEST-INFO | started process screencapture
09:06:07     INFO - TEST-INFO | screencapture: exit 0
09:06:07     INFO - <snipped 28 output lines - if you need more context, please use SimpleTest.requestCompleteLog() in your test>
09:06:07     INFO - Buffered messages logged at 09:06:07
09:06:07     INFO - Console message: [JavaScript Warning: "Unknown property ‘user-select’.  Declaration dropped." {file: "resource://devtools/client/debugger/new/dist/debugger.css?always-parse-css-0.428408033360704" line: 3723}]
09:06:07     INFO - Console message: [JavaScript Warning: "Unknown property ‘offset-inline-end’.  Declaration dropped." {file: "resource://devtools/client/debugger/new/dist/debugger.css?always-parse-css-0.428408033360704" line: 3993}]
09:06:07     INFO - Console message: [JavaScript Warning: "Unknown property ‘offset-inline-start’.  Declaration dropped." {file: "resource://devtools/client/debugger/new/dist/debugger.css?always-parse-css-0.428408033360704" line: 3995}]
09:06:07     INFO - Console message: [JavaScript Warning: "Unknown property ‘user-select’.  Declaration dropped." {file: "resource://devtools/client/debugger/new/dist/debugger.css?always-parse-css-0.428408033360704" line: 4100}]
09:06:07     INFO - Console message: [JavaScript Warning: "Unknown property ‘user-select’.  Declaration dropped." {file: "resource://devtools/client/debugger/new/dist/debugger.css?always-parse-css-0.428408033360704" line: 4144}]
09:06:07     INFO - Console message: [JavaScript Warning: "Unknown property ‘offset-inline-end’.  Declaration dropped." {file: "resource://devtools/client/debugger/new/dist/debugger.css?always-parse-css-0.428408033360704" line: 4154}]
09:06:07     INFO - Console message: [JavaScript Warning: "Unknown property ‘offset-inline-start’.  Declaration dropped." {file: "resource://devtools/client/debugger/new/dist/debugger.css?always-parse-css-0.428408033360704" line: 4156}]
09:06:07     INFO - Console message: [JavaScript Warning: "Unknown property ‘user-select’.  Declaration dropped." {file: "resource://devtools/client/debugger/new/dist/debugger.css?always-parse-css-0.428408033360704" line: 4227}]
09:06:07     INFO - Console message: [JavaScript Warning: "Unknown property ‘user-select’.  Declaration dropped." {file: "resource://devtools/client/debugger/new/dist/debugger.css?always-parse-css-0.428408033360704" line: 4478}]
09:06:07     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 15}]
09:06:07     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 29}]
09:06:07     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 50}]
09:06:07     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 62}]
09:06:07     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 68}]
09:06:07     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 72}]
09:06:07     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 78}]
09:06:07     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 84}]
09:06:07     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 88}]
09:06:07     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 92}]
09:06:07     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 96}]
09:06:07     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 100}]
09:06:07     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 104}]
09:06:07     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 111}]
09:06:07     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 122}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 130}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 150}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 155}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 160}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 171}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 178}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 187}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 196}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 200}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 206}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 213}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 222}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 230}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 234}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 240}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 246}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 255}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 260}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 265}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 275}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 282}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 289}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 296}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 301}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 306}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 311}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 316}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 323}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 330}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 335}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 345}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 353}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 357}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 361}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 365}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 369}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 378}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 382}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 387}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 400}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 408}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 412}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 419}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 425}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 441}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 446}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 453}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 464}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 491}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 501}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 524}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 530}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 533}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 539}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 542}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 546}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 556}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 566}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 586}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 591}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 610}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 614}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 619}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 631}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 635}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 639}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 645}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 650}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 656}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 661}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 666}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 670}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 674}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.428408033360704" line: 681}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown property ‘-moz-border-radius’.  Declaration dropped." {file: "chrome://devtools/content/sourceeditor/codemirror/lib/codemirror.css?always-parse-css-0.428408033360704" line: 241}]
09:06:08     INFO - Console message: [JavaScript Warning: "Unknown property ‘user-select’.  Declaration dropped." {file: "resource://devtools/client/shared/components/reps/reps.css" line: 306}]
09:06:08     INFO - Buffered messages finished
09:06:08     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_parsable_css.js | custom property `--grey-90-a10` is not referenced - 
09:06:08     INFO - Stack trace:
09:06:08     INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_parsable_css.js:checkAllTheCSS:434
09:06:08     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1093
09:06:08     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1084
09:06:08     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:986
09:06:08     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:795
09:06:08     INFO - Ignored error "Unknown property ‘user-select’.  Declaration dropped." on resource://devtools-client-shared/components/reps/reps.css because of whitelist item {"sourceName":"/devtools-client-shared\\/components\\/reps\\/reps.css/i","isFromDevTools":true,"used":true}
09:06:08     INFO - Ignored error "Unknown property ‘user-select’.  Declaration dropped." on resource://devtools/client/debugger/new/dist/debugger.css because of whitelist item {"sourceName":"/devtools\\/client\\/debugger\\/new\\/dist\\/debugger.css/i","isFromDevTools":true,"used":true}
09:06:08     INFO - Ignored error "Unknown property ‘user-select’.  Declaration dropped." on resource://devtools/client/debugger/new/dist/debugger.css because of whitelist item {"sourceName":"/devtools\\/client\\/debugger\\/new\\/dist\\/debugger.css/i","isFromDevTools":true,"used":true}
09:06:08     INFO - Ignored error "Unknown property ‘user-select’.  Declaration dropped." on resource://devtools/client/debugger/new/dist/debugger.css because of whitelist item {"sourceName":"/devtools\\/client\\/debugger\\/new\\/dist\\/debugger.css/i","isFromDevTools":true,"used":true}
09:06:08     INFO - Ignored error "Unknown property ‘appearance’.  Declaration dropped." on resource://devtools/client/debugger/new/dist/debugger.css because of whitelist item {"sourceName":"/devtools\\/client\\/debugger\\/new\\/dist\\/debugger.css/i","isFromDevTools":true,"used":true}
09:06:08     INFO - Ignored error "Unknown property ‘user-select’.  Declaration dropped." on resource://devtools/client/debugger/new/dist/debugger.css because of whitelist item {"sourceName":"/devtools\\/client\\/debugger\\/new\\/dist\\/debugger.css/i","isFromDevTools":true,"used":true}
09:06:08     INFO - Ignored error "Error in parsing value for ‘display’.  Declaration dropped." on resource://devtools/client/debugger/new/dist/debugger.css because of whitelist item {"sourceName":"/devtools\\/client\\/debugger\\/new\\/dist\\/debugger.css/i","isFromDevTools":true,"used":true}
09:06:08     INFO - Ignored error "Unknown property ‘user-select’.  Declaration dropped." on resource://devtools/client/debugger/new/dist/debugger.css because of whitelist item {"sourceName":"/devtools\\/client\\/debugger\\/new\\/dist\\/debugger.css/i","isFromDevTools":true,"used":true}
09:06:08     INFO - Ignored error "Unknown property ‘user-select’.  Declaration dropped." on resource://devtools/client/debugger/new/dist/debugger.css because of whitelist item {"sourceName":"/devtools\\/client\\/debugger\\/new\\/dist\\/debugger.css/i","isFromDevTools":true,"used":true}
09:06:08     INFO - Ignored error "Unknown property ‘user-select’.  Declaration dropped." on resource://devtools/client/debugger/new/dist/debugger.css because of whitelist item {"sourceName":"/devtools\\/client\\/debugger\\/new\\/dist\\/debugger.css/i","isFromDevTools":true,"used":true}
09:06:08     INFO - Ignored error "Unknown property ‘user-select’.  Declaration dropped." on resource://devtools/client/debugger/new/dist/debugger.css because of whitelist item {"sourceName":"/devtools\\/client\\/debugger\\/new\\/dist\\/debugger.css/i","isFromDevTools":true,"used":true}
09:06:08     INFO - Ignored error "Unknown property ‘user-select’.  Declaration dropped." on resource://devtools/client/debugger/new/dist/debugger.css because of whitelist item {"sourceName":"/devtools\\/client\\/debugger\\/new\\/dist\\/debugger.css/i","isFromDevTools":true,"used":true}
09:06:08     INFO - Ignored error "Unknown property ‘user-select’.  Declaration dropped." on resource://devtools/client/debugger/new/dist/debugger.css because of whitelist item {"sourceName":"/devtools\\/client\\/debugger\\/new\\/dist\\/debugger.css/i","isFromDevTools":true,"used":true}
09:06:08     INFO - Ignored error "Unknown property ‘user-select’.  Declaration dropped." on resource://devtools/client/debugger/new/dist/debugger.css because of whitelist item {"sourceName":"/devtools\\/client\\/debugger\\/new\\/dist\\/debugger.css/i","isFromDevTools":true,"used":true}
09:06:08     INFO - Ignored error "Unknown property ‘user-select’.  Declaration dropped." on resource://devtools/client/debugger/new/dist/debugger.css because of whitelist item {"sourceName":"/devtools\\/client\\/debugger\\/new\\/dist\\/debugger.css/i","isFromDevTools":true,"used":true}
09:06:08     INFO - Ignored error "Unknown property ‘user-select’.  Declaration dropped." on resource://devtools/client/debugger/new/dist/debugger.css because of whitelist item {"sourceName":"/devtools\\/client\\/debugger\\/new\\/dist\\/debugger.css/i","isFromDevTools":true,"used":true}
09:06:08     INFO - Ignored error "Unknown property ‘user-select’.  Declaration dropped." on resource://devtools/client/debugger/new/dist/debugger.css because of whitelist item {"sourceName":"/devtools\\/client\\/debugger\\/new\\/dist\\/debugger.css/i","isFromDevTools":true,"used":true}
09:06:08     INFO - Ignored error "Error in parsing value for ‘display’.  Declaration dropped." on resource://devtools/client/debugger/new/dist/debugger.css because of whitelist item {"sourceName":"/devtools\\/client\\/debugger\\/new\\/dist\\/debugger.css/i","isFromDevTools":true,"used":true}
09:06:08     INFO - Ignored error "Unknown property ‘user-select’.  Declaration dropped." on resource://devtools/client/debugger/new/dist/debugger.css because of whitelist item {"sourceName":"/devtools\\/client\\/debugger\\/new\\/dist\\/debugger.css/i","isFromDevTools":true,"used":true}
09:06:08     INFO - Ignored error "Unknown property ‘offset-inline-end’.  Declaration dropped." on resource://devtools/client/debugger/new/dist/debugger.css because of whitelist item {"sourceName":"/devtools\\/client\\/debugger\\/new\\/dist\\/debugger.css/i","isFromDevTools":true,"used":true}
09:06:08     INFO - Ignored error "Unknown property ‘offset-inline-start’.  Declaration dropped." on resource://devtools/client/debugger/new/dist/debugger.css because of whitelist item {"sourceName":"/devtools\\/client\\/debugger\\/new\\/dist\\/debugger.css/i","isFromDevTools":true,"used":true}
09:06:08     INFO - Ignored error "Unknown property ‘offset-inline-end’.  Declaration dropped." on resource://devtools/client/debugger/new/dist/debugger.css because of whitelist item {"sourceName":"/devtools\\/client\\/debugger\\/new\\/dist\\/debugger.css/i","isFromDevTools":true,"used":true}
09:06:08     INFO - Ignored error "Unknown property ‘user-select’.  Declaration dropped." on resource://devtools/client/debugger/new/dist/debugger.css because of whitelist item {"sourceName":"/devtools\\/client\\/debugger\\/new\\/dist\\/debugger.css/i","isFromDevTools":true,"used":true}
09:06:08     INFO - Ignored error "Unknown property ‘user-select’.  Declaration dropped." on resource://devtools/client/debugger/new/dist/debugger.css because of whitelist item {"sourceName":"/devtools\\/client\\/debugger\\/new\\/dist\\/debugger.css/i","isFromDevTools":true,"used":true}
09:06:08     INFO - Ignored error "Unknown property ‘user-select’.  Declaration dropped." on resource://devtools/client/debugger/new/dist/debugger.css because of whitelist item {"sourceName":"/devtools\\/client\\/debugger\\/new\\/dist\\/debugger.css/i","isFromDevTools":true,"used":true}
09:06:08     INFO - Ignored error "Unknown property ‘user-select’.  Declaration dropped." on resource://devtools/client/debugger/new/dist/debugger.css because of whitelist item {"sourceName":"/devtools\\/client\\/debugger\\/new\\/dist\\/debugger.css/i","isFromDevTools":true,"used":true}
09:06:08     INFO - Ignored error "Unknown property ‘offset-inline-end’.  Declaration dropped." on resource://devtools/client/debugger/new/dist/debugger.css because of whitelist item {"sourceName":"/devtools\\/client\\/debugger\\/new\\/dist\\/debugger.css/i","isFromDevTools":true,"used":true}
09:06:08     INFO - Ignored error "Unknown property ‘offset-inline-start’.  Declaration dropped." on resource://devtools/client/debugger/new/dist/debugger.css because of whitelist item {"sourceName":"/devtools\\/client\\/debugger\\/new\\/dist\\/debugger.css/i","isFromDevTools":true,"used":true}
09:06:08     INFO - Ignored error "Unknown property ‘user-select’.  Declaration dropped." on resource://devtools/client/debugger/new/dist/debugger.css because of whitelist item {"sourceName":"/devtools\\/client\\/debugger\\/new\\/dist\\/debugger.css/i","isFromDevTools":true,"used":true}
09:06:08     INFO - Ignored error "Unknown property ‘user-select’.  Declaration dropped." on resource://devtools/client/debugger/new/dist/debugger.css because of whitelist item {"sourceName":"/devtools\\/client\\/debugger\\/new\\/dist\\/debugger.css/i","isFromDevTools":true,"used":true}
09:06:08     INFO - Ignored error "Unknown property ‘offset-inline-end’.  Declaration dropped." on resource://devtools/client/debugger/new/dist/debugger.css because of whitelist item {"sourceName":"/devtools\\/client\\/debugger\\/new\\/dist\\/debugger.css/i","isFromDevTools":true,"used":true}
09:06:08     INFO - Ignored error "Unknown property ‘offset-inline-start’.  Declaration dropped." on resource://devtools/client/debugger/new/dist/debugger.css because of whitelist item {"sourceName":"/devtools\\/client\\/debugger\\/new\\/dist\\/debugger.css/i","isFromDevTools":true,"used":true}
09:06:08     INFO - Ignored error "Unknown property ‘user-select’.  Declaration dropped." on resource://devtools/client/debugger/new/dist/debugger.css because of whitelist item {"sourceName":"/devtools\\/client\\/debugger\\/new\\/dist\\/debugger.css/i","isFromDevTools":true,"used":true}
09:06:08     INFO - Ignored error "Unknown property ‘user-select’.  Declaration dropped." on resource://devtools/client/debugger/new/dist/debugger.css because of whitelist item {"sourceName":"/devtools\\/client\\/debugger\\/new\\/dist\\/debugger.css/i","isFromDevTools":true,"used":true}
0
Flags: needinfo?(lba_2)
(Assignee)

Comment 20

5 months ago
Honza, 
I looked at the failed integration test. If I am reading it correctly, it says that the var(--grey-90-a10) is defined but not used. 

I traced back that it was introduced in (patch from) Bug 1458092 at the same time as the changes that I am removing in this patch. 
So I removed the definition of this var(--grey-90-a10) from devtools/client/themes/variables.css as well.

But at the same time in Bug 1458092 were also other colors introduced: https://hg.mozilla.org/mozreview/gecko/diff/dac40933d6e0/devtools/client/themes/variables.css

But the test doesn't fail for those properties. So I am assuming that it is used somewhere...

Can you confirm I understand that correctly? If yes, pls review the new patch that includes this change in variables.css
thanks,
Lenka
Flags: needinfo?(lba_2)
(Assignee)

Comment 21

5 months ago
Please see the previous comment.
Attachment #9020939 - Attachment is obsolete: true
Attachment #9021296 - Flags: review?(odvarko)
Comment on attachment 9021296 [details] [diff] [review]
toolbar5.patch

Review of attachment 9021296 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for quick update!

R+ Makes sense to me, let's try to land again.

Honza
Attachment #9021296 - Flags: review?(odvarko) → review+
Keywords: checkin-needed

Comment 23

5 months ago
Pushed by nerli@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/44cacc066596
Polish Network panel filter buttons UI; r=Honza
Keywords: checkin-needed

Comment 24

5 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/44cacc066596
Status: ASSIGNED → RESOLVED
Last Resolved: 5 months ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
Whiteboard: good-first-bug → good-first-bug, [good first verify]

I have reproduced this bug with Nightly 64.0a1 (2018-10-18) on Windows 7, 64 Bit! This bug's fix is verified with latest Beta 65.0b10!

Build ID : 20190110221328
User Agent : Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:65.0) Gecko/20100101 Firefox/65.0

Whiteboard: good-first-bug, [good first verify] → good-first-bug, [good first verify] [testday20190111]
You need to log in before you can comment on or make changes to this bug.