Closed Bug 1500068 Opened 2 years ago Closed 2 years ago

Avoid loading add-ons panel when a location hash is given to open any other panel, like workers

Categories

(DevTools :: about:debugging, enhancement, P2)

Product:
DevTools
Component:
about:debugging
Type:
enhancement

Tracking

(firefox64 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 64
Tracking Flags:
Tracking Status
firefox64 --- fixed

People

(Reporter: ochameau, Assigned: ochameau)

References

Details

(Whiteboard: dt-fission)

Attachments

(1 file)

Bug 1500068 - Avoid opening Add-ons panel when a location hash is passed to select another one.
46 bytes, text/x-phabricator-request
Details | Review 
By default, the add-ons panel is displayed:
https://searchfox.org/mozilla-central/rev/eef79962ba73f7759fd74da658f6e5ceae0fc730/devtools/client/aboutdebugging/components/Aboutdebugging.js#63

Only later, on componentDidMount, it is updated to the location hash's one:
https://searchfox.org/mozilla-central/rev/eef79962ba73f7759fd74da658f6e5ceae0fc730/devtools/client/aboutdebugging/components/Aboutdebugging.js#72

So even if we are trying to load directly a given panel via location hash, we always try to load the addons.

This behavior introduces some complexity in bug 1485661 as we now have to explicitely wait for some requessts done by the add-ons panel.
Severity: normal → enhancement
Priority: -- → P2
Summary: Avoid loading adonns panel when a location hash is given to open any other panel, like workers → Avoid loading add-ons panel when a location hash is given to open any other panel, like workers
Doing this avoid loading the addons panel and doing its related requests,
which may still be pending after closing about:debugging.

MozReview-Commit-ID: LJjaE5YVgXi

Depends on D8867
Attachment #9018228 - Attachment description: Bug 1485661 - Avoid opening Add-ons panel when a location hash is passed to select another one. → Bug 1500068 - Avoid opening Add-ons panel when a location hash is passed to select another one.
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/14a6f6ecebc2
Avoid opening Add-ons panel when a location hash is passed to select another one. r=jdescottes
https://hg.mozilla.org/mozilla-central/rev/14a6f6ecebc2
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox64: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
Whiteboard: dt-fission
You need to log in before you can comment on or make changes to this bug.