Add metrics test for netmonitor
Categories
(DevTools :: General, enhancement, P3)
Tracking
(firefox67 fixed)
| Tracking | Status | |
|---|---|---|
| firefox67 | --- | fixed |
People
(Reporter: jdescottes, Assigned: jdescottes)
References
(Blocks 1 open bug)
Details
Attachments
(3 files, 1 obsolete file)
Similar to the inspector metrics test that lands with Bug 1458194, add a metrics test for the netmonitor. See also Bug 1500069 (console metrics test) as it might require some of the same tricks to get access to all the loaders used by the netmonitor.
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Comment 1•4 years ago
|
||
Depends on D19364
|
|
Assignee | |
Comment 2•4 years ago
|
||
Depends on D19582
|
||
Updated•4 years ago
|
|
|
Assignee | |
Comment 3•4 years ago
|
||
Depends on D19582
|
|
Assignee | |
Comment 4•4 years ago
|
||
Depends on D19638
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a11b90e9e698 Add a shared helper to record metrics in tests;r=ochameau https://hg.mozilla.org/integration/autoland/rev/9d792d03c36b Add browserLoader reference on window when flags.testing is true;r=ochameau https://hg.mozilla.org/integration/autoland/rev/7cb353ea123d Add metrics test for netmonitor;r=ochameau
|
||
Comment 6•4 years ago
|
||
Backed out 4 changesets (Bug 1500074, Bug 1500072) for devtools failures in browser_browserloader_mocks.js CLOSED TREE
Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=e381b765ee73175412f8af0f787f7fc37b172bd0
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=228165511&repo=autoland&lineNumber=3191
Backout: https://hg.mozilla.org/integration/autoland/rev/a3ef08e9f99eef0259811cbc01bfc79624647fc5
|
|
Assignee | |
Comment 7•4 years ago
|
||
sorry about that, test only code, removed the additional property in the failing test. Pushed again.
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/accf4033d8cc Add a shared helper to record metrics in tests;r=ochameau https://hg.mozilla.org/integration/autoland/rev/4003039a82c0 Add browserLoader reference on window when flags.testing is true;r=ochameau https://hg.mozilla.org/integration/autoland/rev/7e6a4063398d Add metrics test for netmonitor;r=ochameau
|
||
Comment 9•4 years ago
|
||
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=228186658&repo=autoland&lineNumber=7251
Backout link: https://hg.mozilla.org/integration/autoland/rev/97dd82032154dbd6373cfadb105e194b904b9d49
[task 2019-02-13T14:56:14.102Z] 14:56:14 INFO - TEST-PASS | devtools/client/shared/test/browser_require_raw.js | raw browserRequire worked -
[task 2019-02-13T14:56:14.103Z] 14:56:14 INFO - Buffered messages finished
[task 2019-02-13T14:56:14.105Z] 14:56:14 INFO - TEST-UNEXPECTED-FAIL | devtools/client/shared/test/browser_require_raw.js | test left unexpected property on window: getBrowserLoaderForWindow -
[task 2019-02-13T14:56:14.106Z] 14:56:14 INFO - GECKO(3395) | MEMORY STAT | vsize 20974420MB | residentFast 1399MB
[task 2019-02-13T14:56:14.107Z] 14:56:14 INFO - TEST-OK | devtools/client/shared/test/browser_require_raw.js | took 69ms
|
|
Assignee | |
Comment 10•4 years ago
•
|
||
pushed to try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=538691d336c3ca4ccc4c5a97a059456c81519617
|
||
Comment 11•4 years ago
|
||
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ac92eed544e9 Add a shared helper to record metrics in tests;r=ochameau https://hg.mozilla.org/integration/autoland/rev/0fb5dc2c5657 Add browserLoader reference on window when flags.testing is true;r=ochameau https://hg.mozilla.org/integration/autoland/rev/785a3ad7dc4f Add metrics test for netmonitor;r=ochameau
|
||
Comment 12•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/ac92eed544e9
https://hg.mozilla.org/mozilla-central/rev/0fb5dc2c5657
https://hg.mozilla.org/mozilla-central/rev/785a3ad7dc4f
Description
•