Add metrics test for netmonitor

RESOLVED FIXED in Firefox 67

Status

enhancement
P3
normal
RESOLVED FIXED
8 months ago
4 months ago

People

(Reporter: jdescottes, Assigned: jdescottes)

Tracking

(Blocks 1 bug)

unspecified
Firefox 67
Dependency tree / graph

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(3 attachments, 1 obsolete attachment)

Assignee

Description

8 months ago
Similar to the inspector metrics test that lands with Bug 1458194, add a metrics test for the netmonitor.

See also Bug 1500069 (console metrics test) as it might require some of the same tricks to get access to all the loaders used by the netmonitor.
Assignee

Updated

4 months ago
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Assignee

Comment 2

4 months ago

Depends on D19582

Attachment #9043432 - Attachment is obsolete: true

Comment 5

4 months ago
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a11b90e9e698
Add a shared helper to record metrics in tests;r=ochameau
https://hg.mozilla.org/integration/autoland/rev/9d792d03c36b
Add browserLoader reference on window when flags.testing is true;r=ochameau
https://hg.mozilla.org/integration/autoland/rev/7cb353ea123d
Add metrics test for netmonitor;r=ochameau
Assignee

Comment 7

4 months ago

sorry about that, test only code, removed the additional property in the failing test. Pushed again.

Flags: needinfo?(jdescottes)

Comment 8

4 months ago
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/accf4033d8cc
Add a shared helper to record metrics in tests;r=ochameau
https://hg.mozilla.org/integration/autoland/rev/4003039a82c0
Add browserLoader reference on window when flags.testing is true;r=ochameau
https://hg.mozilla.org/integration/autoland/rev/7e6a4063398d
Add metrics test for netmonitor;r=ochameau

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&fromchange=81a368ce384794df915fbe8ca888b49f2fcc6aee&tochange=23a24796db2bb56ec2172f747fcd1c6dbc23c358&searchStr=devtools&selectedJob=228186006

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=228186658&repo=autoland&lineNumber=7251

Backout link: https://hg.mozilla.org/integration/autoland/rev/97dd82032154dbd6373cfadb105e194b904b9d49

[task 2019-02-13T14:56:14.102Z] 14:56:14 INFO - TEST-PASS | devtools/client/shared/test/browser_require_raw.js | raw browserRequire worked -
[task 2019-02-13T14:56:14.103Z] 14:56:14 INFO - Buffered messages finished
[task 2019-02-13T14:56:14.105Z] 14:56:14 INFO - TEST-UNEXPECTED-FAIL | devtools/client/shared/test/browser_require_raw.js | test left unexpected property on window: getBrowserLoaderForWindow -
[task 2019-02-13T14:56:14.106Z] 14:56:14 INFO - GECKO(3395) | MEMORY STAT | vsize 20974420MB | residentFast 1399MB
[task 2019-02-13T14:56:14.107Z] 14:56:14 INFO - TEST-OK | devtools/client/shared/test/browser_require_raw.js | took 69ms

Flags: needinfo?(jdescottes)

Comment 11

4 months ago
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ac92eed544e9
Add a shared helper to record metrics in tests;r=ochameau
https://hg.mozilla.org/integration/autoland/rev/0fb5dc2c5657
Add browserLoader reference on window when flags.testing is true;r=ochameau
https://hg.mozilla.org/integration/autoland/rev/785a3ad7dc4f
Add metrics test for netmonitor;r=ochameau

Comment 12

4 months ago
bugherder
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
You need to log in before you can comment on or make changes to this bug.