Closed Bug 1500072 Opened 2 years ago Closed 2 years ago

Add metrics test for netmonitor

Categories

(DevTools :: General, enhancement, P3)

enhancement

Tracking

(firefox67 fixed)

RESOLVED FIXED
Firefox 67
Tracking Status
firefox67 --- fixed

People

(Reporter: jdescottes, Assigned: jdescottes)

References

(Blocks 1 open bug)

Details

Attachments

(3 files, 1 obsolete file)

Similar to the inspector metrics test that lands with Bug 1458194, add a metrics test for the netmonitor.

See also Bug 1500069 (console metrics test) as it might require some of the same tricks to get access to all the loaders used by the netmonitor.
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED

Depends on D19582

Attachment #9043432 - Attachment is obsolete: true
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a11b90e9e698
Add a shared helper to record metrics in tests;r=ochameau
https://hg.mozilla.org/integration/autoland/rev/9d792d03c36b
Add browserLoader reference on window when flags.testing is true;r=ochameau
https://hg.mozilla.org/integration/autoland/rev/7cb353ea123d
Add metrics test for netmonitor;r=ochameau

sorry about that, test only code, removed the additional property in the failing test. Pushed again.

Flags: needinfo?(jdescottes)
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/accf4033d8cc
Add a shared helper to record metrics in tests;r=ochameau
https://hg.mozilla.org/integration/autoland/rev/4003039a82c0
Add browserLoader reference on window when flags.testing is true;r=ochameau
https://hg.mozilla.org/integration/autoland/rev/7e6a4063398d
Add metrics test for netmonitor;r=ochameau

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&fromchange=81a368ce384794df915fbe8ca888b49f2fcc6aee&tochange=23a24796db2bb56ec2172f747fcd1c6dbc23c358&searchStr=devtools&selectedJob=228186006

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=228186658&repo=autoland&lineNumber=7251

Backout link: https://hg.mozilla.org/integration/autoland/rev/97dd82032154dbd6373cfadb105e194b904b9d49

[task 2019-02-13T14:56:14.102Z] 14:56:14 INFO - TEST-PASS | devtools/client/shared/test/browser_require_raw.js | raw browserRequire worked -
[task 2019-02-13T14:56:14.103Z] 14:56:14 INFO - Buffered messages finished
[task 2019-02-13T14:56:14.105Z] 14:56:14 INFO - TEST-UNEXPECTED-FAIL | devtools/client/shared/test/browser_require_raw.js | test left unexpected property on window: getBrowserLoaderForWindow -
[task 2019-02-13T14:56:14.106Z] 14:56:14 INFO - GECKO(3395) | MEMORY STAT | vsize 20974420MB | residentFast 1399MB
[task 2019-02-13T14:56:14.107Z] 14:56:14 INFO - TEST-OK | devtools/client/shared/test/browser_require_raw.js | took 69ms

Flags: needinfo?(jdescottes)
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ac92eed544e9
Add a shared helper to record metrics in tests;r=ochameau
https://hg.mozilla.org/integration/autoland/rev/0fb5dc2c5657
Add browserLoader reference on window when flags.testing is true;r=ochameau
https://hg.mozilla.org/integration/autoland/rev/785a3ad7dc4f
Add metrics test for netmonitor;r=ochameau
You need to log in before you can comment on or make changes to this bug.