1500098 - The user is unable to open multiple tabs in Container

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect, P3)

Description

[Rares Doghi, Desktop QA]

[Affected versions]: 
Nightly 64.0a1

[Affected platforms]:
Platforms: All


[Steps to reproduce]:
1. Open the Firefox browser and open a few websites in new tabs (youtube, reddit, Facebook).
2. Right Click one of the tabs and Click Select all Tabs.
3. Right Click one of the Tabs and click Reopen in Container (any container is fine).

Expected Result:
The Selected tabs should reopen in the Specified container.

Actual Results:
Even though multiple tabs are selected, only the tab that the user right clicks will open in a new Container.

Please note that after selecting all tabs the user is able to move, bookmark, mute or reload all tabs at once without issues.

Comment 1

[Dão Gottwald [:dao]]

Jared, can you please prioritize this? Thanks.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Abdoulaye, could you work on this?

Comment 3

[Abdoulaye O. LY]

Yes, thank you for suggesting this to me.

Comment 4

[Abdoulaye O. LY]

Attachment: Bug 1500098 - Reopen multi-selected tabs in container. r?jaws,Gijs

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/05331fb8f533
Reopen multi-selected tabs in container. r=Gijs

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/05331fb8f533

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 9023170 [details]
Bug 1500098 - Reopen multi-selected tabs in container. r?jaws,Gijs

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: multiselect tabs

User impact if declined: Trying to reopen multiple tabs in a container fails with no feedback to the user as to why

Is this code covered by automated tests?: Yes

Has the fix been verified in Nightly?: No

Needs manual test from QE?: No

If yes, steps to reproduce: 

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): The patch is covered by tests and is centralized on just the Reopen In Container functionality

String changes made/needed: none

Comment 8

[Mohammad Maruf Rahman]

I have reproduced this bug with Nightly 64.0a1 (2018-10-18) on Windows 7, 64 Bit!
This bug's fix is verified with latest Nightly!

Build ID 	20181112220107
User Agent 	Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:65.0) Gecko/20100101 Firefox/65.0

Comment 9

[Julien Cristau [:jcristau] (back April 22)]

Comment on attachment 9023170 [details]
Bug 1500098 - Reopen multi-selected tabs in container. r?jaws,Gijs

bug fix for multiselect tabs, approved for 64.0b10

Comment 10

[Rares Doghi, Desktop QA]

Based on Comment 8 and checking this myself in 65.0a1 (2018-11-13) I will set the flags for it to Verified in Fx65.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/5505a22a57d0

Comment 12

[Rares Doghi, Desktop QA]

Hi, This issue no longer occurs in Firefox beta 64.0b12, I will mark this issue accordingly.