1500118 - Build bustage: out/gecko/structs.rs:587:11595: error[E0412]: cannot find type `T` in this scope

Status: RESOLVED WORKSFORME

(Core :: CSS Parsing and Computation, defect, P2)

Description

[Honza Bambas (:mayhemer)]

Attachment: patch to demo

Full error log will be added in an attachment to make it more readable (long lines).

Windows debug build, on few days old m-c.

STR:
- update m-c to 00676b03ab53
- apply the attached patch
- ./mach build

In a nut shell: I've added few new templates to mozglue, under a new dir `backtrack`.  When I create a new member with type being one of those templates in the nsIDocument class, I start getting these build errors.

The minimal change that introduces this build error is the new 

mozilla::backtrack::Queue<nsCOMPtr<nsIRunnable>> mFrameLoaderFinalizers__

member in dom\base\nsIDocument.h, line 4687.  If you comment that out, the tree builds.

Comment 1

[Honza Bambas (:mayhemer)]

Attachment: build error log (snippet)

Comment 2

[Honza Bambas (:mayhemer)]

Guys, can you please help?  This really blocks me, thanks.

Comment 3

[(not currently active) Ted Mielczarek]

This isn't a build system problem, it's a problem with the stylo build script that runs bindgen to generate Rust code from Gecko C++ types. I don't know the answer, but emilio should. I would guess you need to make a change to ServoBindings.toml:
https://dxr.mozilla.org/mozilla-central/source/layout/style/ServoBindings.toml

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: patch

Yeah, sorry for the hassle... Bindgen gets somewhat confused when template parameters aren't just types, mostly because libclang doesn't expose them. The PageSize parameter in Queue is the one that's causing it to fall apart.

This allows me to build, you can land it with r=emilio when you please.

Comment 5

[Honza Bambas (:mayhemer)]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #4)
> Created attachment 9018310 [details] [diff] [review]
> patch
> 
> Yeah, sorry for the hassle... Bindgen gets somewhat confused when template
> parameters aren't just types, mostly because libclang doesn't expose them.
> The PageSize parameter in Queue is the one that's causing it to fall apart.
> 
> This allows me to build, you can land it with r=emilio when you please.

Thanks for such a quick reply, Emilio!  This works for me.  I will land along with patches in bug 1148204.