Closed Bug 1500129 Opened 3 years ago Closed 3 years ago

Clean up gStoragePressureObserver's openPreferences call

Categories

(Firefox :: General, enhancement, P3)

Product:
Firefox
Component:
General
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 65
Tracking Flags:
Tracking Status
firefox65 --- fixed

People

(Reporter: dao, Assigned: spiro, Mentored)

Details

(Keywords: good-first-bug, Whiteboard: [lang=js])

Attachments

(1 file)

Bug 1500129 - Cleaned up openPreferences call.
46 bytes, text/x-phabricator-request
Details | Review 
This code already runs in the right window where openPreferences is available, so going through gBrowser.ownerGlobal doesn't seem to make any sense:

https://searchfox.org/mozilla-central/rev/eef79962ba73f7759fd74da658f6e5ceae0fc730/browser/base/content/browser.js#595-596

We can simplify this to just:

openPreferences("privacy-sitedata", { origin: "storagePressure" });
Assignee: nobody → sharma.divyansh.501
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bb60a56fe1d0
Cleaned up openPreferences call. r=dao
https://hg.mozilla.org/mozilla-central/rev/bb60a56fe1d0
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
You need to log in before you can comment on or make changes to this bug.