Remove urlbar.matchBehavior and merge some of the behaviors

RESOLVED FIXED in Firefox 65

Status

()

P1
normal
RESOLVED FIXED
4 months ago
4 months ago

People

(Reporter: mak, Assigned: mak)

Tracking

unspecified
Firefox 65
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox65 fixed)

Details

(Whiteboard: [fxsearch])

Attachments

(1 attachment)

(Assignee)

Description

4 months ago
browser.urlbar.matchBehavior is a pref that allows, by setting obscure values, to change the matching mode of the urlbar. possible values are:
  MATCH_ANYWHERE,
  MATCH_BOUNDARY_ANYWHERE,
  MATCH_BOUNDARY,
  MATCH_BEGINNING,
  MATCH_BEGINNING_CASE_SENSITIVE,
exposed by mozIPlacesAutoComplete.

A few of these are not used, others can be merged.

All of this complicates things, and the outcome is not much clear, we don't experiment with these from a long long time, and the default behavior always satisfied users needs.

All that we need is:
1. Search on boundary and then, if not enough results were found) everywhere
2. search unmodified strings (no trimming)
(Assignee)

Comment 1

4 months ago
Created attachment 9020071 [details]
Bug 1500138 - Remove browser.urlbar.matchBehavior and some unused Address Bar behaviors. r=adw!

Remove browser.urlbar.matchBehavior pref. Remove code for BEGINNING behaviors, and stop referencing MATCH_BOUNDARY_ANYWHERE from our code.

Comment 2

4 months ago
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/095cb0042729
Remove browser.urlbar.matchBehavior and some unused Address Bar behaviors. r=adw

Comment 3

4 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/095cb0042729
Status: ASSIGNED → RESOLVED
Last Resolved: 4 months ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
(Assignee)

Updated

4 months ago
Depends on: 1502728
You need to log in before you can comment on or make changes to this bug.