1500142 - Remove inspector bindings from toolbox

Status: RESOLVED FIXED

(DevTools :: Inspector, enhancement, P1)

Description

[Yulia Startsev [:yulia]]

The toolbox currently holds a reference to the inspector. This is no longer necessary, as we have that available on the target via getFront, and in a number of other places. This will also enable fission work, as the toolbox will no longer hold references to target specific fronts

Tasks: Remove inspector bindings from toolbox 
* [This needs to go away](https://searchfox.org/mozilla-central/rev/3d469329a42644b41e66944d8da22d78d8c0f5ec/devtools/shared/fronts/targets/target-mixin.js#185-193) and we should just use “getFront” everywhere
* Update tests so that they do not fail 
  * The [old destroy path](https://searchfox.org/mozilla-central/rev/c606cdd6d014fee4034da1702d484c0d41b604c9/devtools/client/framework/toolbox.js#3071-3095). 
  * The [new destroy path](https://searchfox.org/mozilla-central/rev/c606cdd6d014fee4034da1702d484c0d41b604c9/devtools/shared/fronts/targets/target-mixin.js#528-531)
* Use [target.onFront](https://searchfox.org/mozilla-central/source/devtools/shared/fronts/targets/target-mixin.js#191-197) to do [inspector toolbox instantiation](https://searchfox.org/mozilla-central/source/devtools/client/framework/toolbox.js#3012-3018)
* [remove bindings]( https://searchfox.org/mozilla-central/rev/c606cdd6d014fee4034da1702d484c0d41b604c9/devtools/client/framework/toolbox.js#3007-3010)

Comment 1

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1500142 - Remove inspector bindings from toolbox. r=ochameau,yulia

Depends on D40319

Comment 2

[Gabriel Luong [:gl] (ΦωΦ)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=106276ab09a7ca3f6fdef99c1be507bcfb329c95

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3182a1d6debb
Remove inspector bindings from toolbox. r=ochameau,yulia

Comment 4

[Cristian Brindusan [:cbrindusan]]

Backed out changeset 3182a1d6debb (bug 1500142) for xpcshell failures at test_oob_cert_auth.js.

Backout: https://hg.mozilla.org/integration/autoland/rev/3c359e941e5a96f805fc2dbde9945bf6c6e68ec1

Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=3182a1d6debb009c402ad74fba1c03a1a19966bf&selectedJob=265414065

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=265414065&repo=autoland&lineNumber=2585

Comment 5

[Gabriel Luong [:gl] (ΦωΦ)]

devtools/shared/security/tests/unit/test_oob_cert_auth.js
  FAIL  - A promise chain failed to handle a rejection: Can't manage front without an actor ID.
Ensure server supports root. - stack: manage@resource://devtools/shared/protocol/Front.js:95:13
DebuggerClient/<@resource://devtools/shared/client/debugger-client.js:76:19
emit@resource://devtools/shared/event-emitter.js:190:24
emit@resource://devtools/shared/event-emitter.js:271:18
reject@resource://devtools/shared/client/debugger-client.js:819:15
purgeRequests/<@resource://devtools/shared/client/debugger-client.js:840:53
purgeRequests@resource://devtools/shared/client/debugger-client.js:840:28
onClosed@resource://devtools/shared/client/debugger-client.js:766:10
close@resource://devtools/shared/transport/transport.js:186:18
@/Users/oracle/Projects/fx-team/objdir-frontend/_tests/xpcshell/devtools/shared/security/tests/unit/test_oob_cert_auth.js:142:15
async*run_next_test/_run_next_test/<@/Users/oracle/Projects/fx-team/testing/xpcshell/head.js:1565:22
_run_next_test@/Users/oracle/Projects/fx-team/testing/xpcshell/head.js:1565:38
run@/Users/oracle/Projects/fx-team/testing/xpcshell/head.js:733:9
_do_main@/Users/oracle/Projects/fx-team/testing/xpcshell/head.js:246:6
_execute_test@/Users/oracle/Projects/fx-team/testing/xpcshell/head.js:573:5

This seems to be an existing failure that only surfaced when we converted manage into async. We end up calling debugger-client.js#72 after closing the DebuggerClient and purging the requests. I added a closed check in expectReply("root") handler.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ee21ca668ca8
Remove inspector bindings from toolbox. r=yulia,ochameau

Comment 7

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/ee21ca668ca8