Closed Bug 1500201 Opened 2 years ago Closed 2 years ago

Port Bug 1496581 - Split nsISeekableStream in 2 classes: nsISeekableStream and nsITellableStream

Categories

(MailNews Core :: General, task)

task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 64.0

People

(Reporter: jorgk-bmo, Assigned: jorgk-bmo)

Details

Attachments

(1 file)

mailnews/base/util/nsMsgFileStream.cpp(73,18):  error: out-of-line definition of 'Tell' does not match any declaration in 'nsMsgFileStream'
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/c818d0a484d5
Port Bug 1496581: nsISeekableStream is split into nsISeekableStream and nsITellableStream now. rs=bustage-fix
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 64.0
Version: 60 → Trunk
This already compiles. Modelled on:
https://hg.mozilla.org/mozilla-central/rev/2da6504c901e#l5.13
https://hg.mozilla.org/mozilla-central/rev/2da6504c901e#l6.7

Note that nsITellableStream is not listed at a public superclass.
Assignee: nobody → jorgk
Attachment #9018352 - Flags: review?(acelists)
Comment on attachment 9018352 [details] [diff] [review]
c818d0a484d571351c9e21fb67a06bff37d4cb85.patch

Or perhaps it's best to ask Andrea. This patch works and has landed but perhaps you can explain why our "message file stream" doesn't need to inherit from nsITellableStream when it provides a QI() to it. That's what the NS_IMPL_ISUPPORTS() does if I'm not mistaken.
Attachment #9018352 - Flags: feedback?(amarchesini)
Comment on attachment 9018352 [details] [diff] [review]
c818d0a484d571351c9e21fb67a06bff37d4cb85.patch

Review of attachment 9018352 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm!
Attachment #9018352 - Flags: feedback?(amarchesini) → feedback+
Thanks, but can you please answer the question for our education in comment #3.
Comment on attachment 9018352 [details] [diff] [review]
c818d0a484d571351c9e21fb67a06bff37d4cb85.patch

Review of attachment 9018352 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks. nsISeekableStream inherits from nsITellableStream (at least in the .idl) so maybe that's why we do not need to specify nsITellableStream in the class (but have to elsewhere). It also does not compile specifying nsITellableStream explicitly.
Attachment #9018352 - Flags: review?(acelists) → review+
I noticed that ;-)
Type: defect → task
You need to log in before you can comment on or make changes to this bug.