1500223 - Long commit messages are cut off

Status: RESOLVED FIXED

(Conduit :: Lando, defect, P1)

Description

[Andreas Tolfsen ❲:ato❳]

Attachment: Screenshot 2018-10-18 at 14.02.32.png

Long commit messages are cut off after eight lines as shown by the
attached screenshot.  It would be great if commit messages were
shown in full.

Comment 1

[Jan Henning [:JanH]]

.StackPage-landingPreview-commitMessage uses "overflow-y: hidden" - is there any reason why it couldn't use "overflow-y: scroll" at least?

Comment 2

[Steven MacLeod [:smacleod]]

Definitely just an oversight with the new UI, we should fix this ASAP. (sorry for the delay in triage, was on PTO).

Comment 3

[Nikki Sharpley [:nikkis]]

Attachment: landing preview: extend display of commit messages (Bug 1500223).

Previously, long commit messages were cut off and the overflow was
hidden. This fix removes the max-height limitation to display the
commit message in full. The overflow property was removed as well,
as it is not necessary with this fix.

Comment 4

[Steven MacLeod [:smacleod]]

Thanks for the contribution Nikki :D

https://github.com/mozilla-conduit/lando-ui/commit/33207a28db5d471ffdf10cd086f20a721e44413b

Comment 5

[Mark Côté [:mcote]]

Yes, thanks very much!