Stop relying on getElementByID for anonymous search-suggestions-change-settings element in test

RESOLVED FIXED in Firefox 64

Status

()

defect
RESOLVED FIXED
8 months ago
8 months ago

People

(Reporter: bgrins, Assigned: bgrins)

Tracking

unspecified
Firefox 64
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox64 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

8 months ago
This returns null in browser.xhtml: https://searchfox.org/mozilla-central/rev/c56977420df7a1b692ce0f7e499ddb364d9fd7b2/browser/base/content/test/urlbar/browser_urlbarSearchSuggestions_opt-out.js#58.

I was surprised that this works at all inside of XBL anon content in browser.xul, but I think it's happening at https://searchfox.org/mozilla-central/rev/c56977420df7a1b692ce0f7e499ddb364d9fd7b2/dom/xul/XULDocument.cpp#929.

This is done only in the test (https://searchfox.org/mozilla-central/search?q=search-suggestions-change-settings&path=) so I think this would be safe to use `document.getAnonymousElementByAttribute` instead.

Comment 2

8 months ago
Pushed by bgrinstead@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/53abc33e3e38
Use getAnonymousElementByAttribute instead of getElementByID for XBL anonymous search element;r=dao

Comment 3

8 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/53abc33e3e38
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
Assignee

Updated

8 months ago
See Also: → 1502151
You need to log in before you can comment on or make changes to this bug.