Remove insertItem and currentSet implementations from toolbar bindings

RESOLVED FIXED in Firefox 65

Status

()

task
P1
normal
RESOLVED FIXED
9 months ago
Last month

People

(Reporter: Gijs, Assigned: Gijs)

Tracking

(Blocks 1 bug)

Trunk
Firefox 65
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox63 wontfix, firefox64 wontfix, firefox65 fixed)

Details

Attachments

(2 attachments)

insertItem is basically unused already (and was only ever kept for xpcom add-on compat).

currentSet is almost unused, but has one or two internal uses. We also persist it all over the place, which we can remove, some 35-odd versions after Australis...

It's a bit hairy, but on the other hand also allows us to remove the `legacy` property for toolbars.

This together allows eliminating the menubar-stub binding immediately, and hopefully helps in allowing someone else to fix bug 1493594 and remove the CUI toolbar binding completely.

That'd then leave the draggable toolbar binding and the toolbarpaletteitem binding in the customizableui toolbar.xml file.
I pushed an earlier version to try ( https://treeherder.mozilla.org/#/jobs?repo=try&revision=e3bea8f6626e269e48f0eaa79b470c1d6dfa6db1 ) and that was green, so I don't anticipate issues.
(In reply to :Gijs (he/him) from comment #3)
> I pushed an earlier version to try (
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=e3bea8f6626e269e48f0eaa79b470c1d6dfa6db1 ) and that
> was green, so I don't anticipate issues.

... though I'd obviously land this next week, not in soft freeze...
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/9b894301f1fd
remove customizableui toolbar's insertItem method, r=bgrins
https://hg.mozilla.org/integration/autoland/rev/c78192e00cf3
remove legacy toolbar and currentset support from customizableui, r=jaws
https://hg.mozilla.org/mozilla-central/rev/9b894301f1fd
https://hg.mozilla.org/mozilla-central/rev/c78192e00cf3
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
Marking as wontfix for 64 beta from the size and nature of the changes, but as always please let relman know if you are aiming for uplift.
Type: enhancement → task
You need to log in before you can comment on or make changes to this bug.