1500268 - Remove insertItem and currentSet implementations from toolbar bindings

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, task, P1)

Description

[:Gijs (he/him)]

insertItem is basically unused already (and was only ever kept for xpcom add-on compat).

currentSet is almost unused, but has one or two internal uses. We also persist it all over the place, which we can remove, some 35-odd versions after Australis...

It's a bit hairy, but on the other hand also allows us to remove the `legacy` property for toolbars.

This together allows eliminating the menubar-stub binding immediately, and hopefully helps in allowing someone else to fix bug 1493594 and remove the CUI toolbar binding completely.

That'd then leave the draggable toolbar binding and the toolbarpaletteitem binding in the customizableui toolbar.xml file.

Comment 1

[:Gijs (he/him)]

Attachment: Bug 1500268 - remove legacy toolbar and currentset support from customizableui, r?jaws

Comment 2

[:Gijs (he/him)]

Attachment: Bug 1500268 - remove customizableui toolbar's insertItem method, r?bgrins

Comment 3

[:Gijs (he/him)]

I pushed an earlier version to try ( https://treeherder.mozilla.org/#/jobs?repo=try&revision=e3bea8f6626e269e48f0eaa79b470c1d6dfa6db1 ) and that was green, so I don't anticipate issues.

Comment 4

[:Gijs (he/him)]

(In reply to :Gijs (he/him) from comment #3)
> I pushed an earlier version to try (
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=e3bea8f6626e269e48f0eaa79b470c1d6dfa6db1 ) and that
> was green, so I don't anticipate issues.

... though I'd obviously land this next week, not in soft freeze...

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9b894301f1fd
remove customizableui toolbar's insertItem method, r=bgrins
https://hg.mozilla.org/integration/autoland/rev/c78192e00cf3
remove legacy toolbar and currentset support from customizableui, r=jaws

Comment 6

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/9b894301f1fd
https://hg.mozilla.org/mozilla-central/rev/c78192e00cf3

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Marking as wontfix for 64 beta from the size and nature of the changes, but as always please let relman know if you are aiming for uplift.