Closed
Bug 1500269
Opened 2 years ago
Closed 2 years ago
Upgrade to rustc 1.29.2
Categories
(Firefox Build System :: General, enhancement)
Firefox Build System
General
Tracking
(firefox64 fixed, firefox65 fixed)
RESOLVED
FIXED
mozilla65
People
(Reporter: chmanchester, Assigned: chmanchester)
Details
Attachments
(1 file)
46 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details | Review |
We should land this on central before the merge.
Assignee | ||
Comment 1•2 years ago
|
||
Pushed by cmanchester@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bb935ef08190 Upgrade to rustc 1.29.2 r=glandium
Assignee | ||
Comment 4•2 years ago
|
||
Dang. Thanks for the heads up. Will request uplift when it hits central.
Flags: needinfo?(cmanchester)
Comment 5•2 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/bb935ef08190
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Assignee | ||
Comment 6•2 years ago
|
||
Comment on attachment 9018443 [details] Bug 1500269 - Upgrade to rustc 1.29.2 [Beta/Release Uplift Approval Request] Feature/Bug causing the regression: None User impact if declined: Miscompilation bug in llvm that can trigger panics (and therefore crashes). See https://github.com/rust-lang/rust/pull/54639 for details. Is this code covered by automated tests?: Unknown Has the fix been verified in Nightly?: Yes Needs manual test from QE?: No If yes, steps to reproduce: List of other uplifts needed: None Risk to taking this patch: Low Why is the change risky/not risky? (and alternatives if risky): The rustc 1.29.2 release contains only a small number of fixes on top of the rustc 1.29.0 release that has been used in automation since bug 1490145. String changes made/needed:
Attachment #9018443 -
Flags: approval-mozilla-beta?
Comment 7•2 years ago
|
||
Comment on attachment 9018443 [details] Bug 1500269 - Upgrade to rustc 1.29.2 Updates the Rust compiler from version 1.29.0 to a less-buggy 1.29.2 instead. Approved for 64.0b4.
Attachment #9018443 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 8•2 years ago
|
||
bugherderuplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/d8cc412ec31c
status-firefox64:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•