1500269 - Upgrade to rustc 1.29.2

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Chris Manchester (limited bugmail, email directly)]

We should land this on central before the merge.

Comment 1

[Chris Manchester (limited bugmail, email directly)]

Attachment: Bug 1500269 - Upgrade to rustc 1.29.2

Comment 2

[Ryan VanderMeulen [:RyanVM]]

FYI, this missed the merge :\

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bb935ef08190
Upgrade to rustc 1.29.2 r=glandium

Comment 4

[Chris Manchester (limited bugmail, email directly)]

Dang. Thanks for the heads up. Will request uplift when it hits central.

Comment 5

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/bb935ef08190

Comment 6

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 9018443 [details]
Bug 1500269 - Upgrade to rustc 1.29.2

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: None

User impact if declined: Miscompilation bug in llvm that can trigger panics (and therefore crashes). See https://github.com/rust-lang/rust/pull/54639 for details.

Is this code covered by automated tests?: Unknown

Has the fix been verified in Nightly?: Yes

Needs manual test from QE?: No

If yes, steps to reproduce: 

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): The rustc 1.29.2 release contains only a small number of fixes on top of the rustc 1.29.0 release that has been used in automation since bug 1490145.

String changes made/needed:

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9018443 [details]
Bug 1500269 - Upgrade to rustc 1.29.2

Updates the Rust compiler from version 1.29.0 to a less-buggy 1.29.2 instead. Approved for 64.0b4.

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/releases/mozilla-beta/rev/d8cc412ec31c