1500290 - MSVC builds on beta/release are not using MSVC

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Mike Hommey [:glandium]]

Whatever is making the build use the beta or release mozconfigs for beta and release is overriding the fact that the mozconfig-variant for the msvc builds is opt-msvc or debug-msvc.

Comment 1

[Tom Prince [:tomprince]]

I think this should be fixed by https://phabricator.services.mozilla.com/D8452

Comment 2

[Mike Hommey [:glandium]]

(In reply to Tom Prince [:tomprince] from comment #1)
> I think this should be fixed by
> https://phabricator.services.mozilla.com/D8452

That's the fun part: the mozconfig-variant for the msvc jobs *is* defined in the taskcluster config: https://dxr.mozilla.org/mozilla-central/source/taskcluster/ci/build/windows.yml#933

My guess is that the thing that overrides the mozconfig variant from nightly to beta for the beta branches overrides that.

Comment 3

[Mike Hommey [:glandium]]

The task log on beta says:
18:51:28     INFO - The branch 'mozilla-beta' has custom behavior for the platform 'win32'. Updating self.config with the following from 'platform_overrides' found in 'builds/branch_specifics.py':
18:51:28     INFO - {'mozconfig_variant': 'beta'}

That probably happens after EXTRA_MOZHARNESS_CONFIG is taken into account.

Comment 4

[Tom Prince [:tomprince]]

Yes. `branch_specifics` is applied after EXTRA_MOZHANRESS_CONFIG. Specifically, branch_specifics is applied
https://searchfox.org/mozilla-central/source/testing/mozharness/mozharness/mozilla/building/buildbase.py#313-320
after the up-call
https://searchfox.org/mozilla-central/source/testing/mozharness/mozharness/mozilla/building/buildbase.py#300-303
where EXTRA_MOZHARNESS_CONFIG is applied
https://searchfox.org/mozilla-central/source/testing/mozharness/mozharness/base/config.py#479-481

https://phabricator.services.mozilla.com/D8452 addresses that by moving the where the beta mozconfig-variant is set from `branch_specifics` to the taskgraph defaults, which the specific jobs can override.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Confirmed that MSVC jobs on Beta are now using cl.exe again :). They're PGO-enabled, which is sub-optimal, but not surprising either.

INFO -  checking for the target C compiler... z:/build/build/src/vs2017_15.8.4/VC/bin/Hostx64/x86/cl.exe

Runtimes are also comfortably under 2hr again, even with PGO enabled.