1500321 - Don't run always-targets as part of nightly, cron or rel-pro graphs.

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Tom Prince [:tomprince]]

These tasks should be run as part of every push (although perhaps optimized away), but they should not be run as part of graphs that are not on-push graphs.

Comment 1

[Chris Cooper [:coop] (he/him)]

Tom: is there a downside to this, aside from it perhaps being unnecessary and wasteful?

Comment 2

[Tom Prince [:tomprince]]

It also leads to duplicate jobs showing up on treeherder, which can impact sherrifs. It definitely isn't high priority.

Comment 4

[Cristian Brindusan [:cbrindusan]]

Seen this on mozilla-release as-well:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-release&searchStr=f1930ca42aecc91c3e2dfad93628de7160c99b66&tochange=5c21c7755f9c594d5491332c6c8e1cdc671df87f&fromchange=066c53c8aa9b37529925885a33c94054bc6cfcf5

The ESlint job is ran more than 5-10 times on some pushes.

Comment 5

[Aki Sasaki (not active)]

Should we change always-target to always-target-on-hgpush ? With l10n bumper, we now get always-target tasks every hour, making this much more visible.

Comment 6

[Aki Sasaki (not active)]

I'm currently thinking always-target could be a list of tasks_for (e.g., cron, hg-push, action), but it's likely we only need it for hg-push.

Comment 7

[Aki Sasaki (not active)]

Attachment: Bug 1500321 - only run always-target tasks on hg-push. r=tomprince

Comment 8

[Aki Sasaki (not active)]

I went with the simplest solution.

Comment 9

[Aki Sasaki (not active)]

Attachment: Bug 1500321 - fix taskgraph tests. r=tomprince

Depends on D56608

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f4561c0001c9
only run always-target tasks on hg-push. r=tomprince

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bc2e62c597ac
fix taskgraph tests.

Comment 12

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/f4561c0001c9
https://hg.mozilla.org/mozilla-central/rev/bc2e62c597ac

Comment 13

[Aki Sasaki (not active)]

:Aryx, do we want to uplift this?

Comment 14

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Yes, would prefer uplifts at least for beta and esr68 as less running jobs means less intermittents to classify and the tasks already ran before.

Comment 15

[Aki Sasaki (not active)]

[Tracking Requested - why for this release]:
This will avoid extraneous source test runs for l10n-bumper and the like.

Comment 16

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/releases/mozilla-beta/rev/9dba0492fc75
https://hg.mozilla.org/releases/mozilla-beta/rev/835566201445

Comment 17

[Andreea Pavel [:apavel]]

This does not apply cleanly to esr68, I get a conflict:

warning: conflicts while merging taskcluster/taskgraph/test/test_generator.py! (edit, then use 'hg resolve --mark')

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr68/rev/57f7ac77e633
https://hg.mozilla.org/releases/mozilla-esr68/rev/9dfd889684cb