Closed Bug 1500347 Opened 7 years ago Closed 7 years ago

Port Bug 1492648 - Move from nsDocShellLoadInfo to nsDocShellLoadState

Categories

(MailNews Core :: General, task)

Product:
MailNews Core
Component:
General
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 65.0

People

(Reporter: jorgk-bmo, Assigned: jorgk-bmo)

References

Details

Attachments

(1 file, 1 obsolete file)

fb0fff3cd0f7.patch
12.88 KB, patch
qdot
: review+
Details | Diff | Splinter Review
Patch coming.
Attached patch 1500347-loaduri.patch (obsolete) — — Splinter Review
This should do it.
Assignee: nobody → jorgk
Status: NEW → ASSIGNED
Attachment #9018539 - Flags: review?(bzbarsky)
BTW, what is the "first party load" about. We use it once.
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/3a91ffa3617c Port Bug 1492648: nsIDocShell.loadURI() takes a nsDocShellLoadState parameter now. rs=bustage-fix
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 64.0
Attachment #9018539 - Flags: review?(bzbarsky) → review?(kyle)
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/c7b5816c5071 Backed out changeset 3a91ffa3617c since ported bug 1492648 was backed out. a=backout
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Blocks: 1492648
Pushed by geoff@darktrojan.net: https://hg.mozilla.org/comm-central/rev/fb0fff3cd0f7 Port Bug 1492648: nsIDocShell.loadURI() takes a nsDocShellLoadState parameter now. rs=bustage-fix
Status: REOPENED → RESOLVED
Closed: 7 years ago → 7 years ago
Resolution: --- → FIXED
I missed the boat for Daily, on account of having just 10 minutes to notice the m-c push, and then in a rush attempting to import the backout instead of the actual changes.
Target Milestone: Thunderbird 64.0 → Thunderbird 65.0
Depends on: 1500420
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/0f116c762e79 Backed out changeset fb0fff3cd0f7 since ported bug 1492648 was backed out. a=backout
Status: REOPENED → RESOLVED
Closed: 7 years ago → 7 years ago
Resolution: --- → FIXED
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Ok, relanded bug 1492648 to m-i, now with comments pointing out the need for this change. Should I review this patch now?
Comment on attachment 9018539 [details] [diff] [review] 1500347-loaduri.patch I'll do a new patch. So everywhere I use LOAD_FLAGS_IS_LINK I'll add a call to loadState->SetLoadType(LOAD_LINK), right?
Attachment #9018539 - Flags: review?(kyle)
OK, added the SetLoadType() calls where necessary.
Attachment #9018539 - Attachment is obsolete: true
Attachment #9021089 - Flags: review?(kyle)
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/251d4aa464d2 Port Bug 1492648: nsIDocShell.loadURI() takes a nsDocShellLoadState parameter now. rs=bustage-fix
Status: REOPENED → RESOLVED
Closed: 7 years ago → 7 years ago
Resolution: --- → FIXED
Attachment #9021089 - Flags: review?(kyle) → review+
Type: defect → task
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: