1500352 - Missing previews in theme cards on Windows

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P3)

Description

[Franck (Wip)]

Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:64.0) Gecko/20100101 Firefox/64.0
Build ID: 20181019005426

Bug 1495713 introduced themes preview in the new card design... and that's great!
However, they are not always displayed :-(

Steps to reproduce:
  - use a new profile OR ensure that no extensions/add-ons are installed
  - ensure there is at least one theme installed other than the 3 embedded ones
    (use the "Get Add-ons" section or visit https://addons.mozilla.org/firefox/themes/)
  - select the "Plugins" section and observe the "OpenH264" card is present
  - select the "Themes" section and observe the previews are present
  - select the "Extensions" section and observe the "You don't have any add-ons of this type installed" message
  - select the "Themes" section once again

Actual results:
  the themes preview are missing

Expected results:
  the themes preview should be displayed

I suspect the previews are not displayed if the previous section we are navigating from does not contain any visible card.

Comment 1

[Mark Striemer [:mstriemer]]

I can't reproduce this on my Mac. Does this happen every time you switch from Extensions to Themes with no Extensions installed? I will check on my Windows PC at home later as well.

Comment 2

[Mark Striemer [:mstriemer]]

I can reproduce this on Windows.

Comment 3

[Franck (Wip)]

Sorry for the late reply.
And yes, this happen every time I switch from "Extensions" to "Themes" with no extensions installed.

Switching from "Plugins" to "Themes" does not trigger the bug.
However there can be no plugins with OpenH264 not removable.
I can't test what is happening with no plugins installed.

Oddly, switching from "Get Add-ons" to "Themes" triggers the bug depending of the navigation:
 - Themes     -> Get Add-ons -> Themes  ==> OK
 - Plugins    -> Get Add-ons -> Themes  ==> OK
 - Extensions -> Get Add-ons -> Themes  ==> bug

So, even indirectly switching from "Extensions" to "Themes" through "Get Add-ons" triggers the bug.
Don't know if this helps...

Comment 4

[Mark Striemer [:mstriemer]]

Attachment: Bug 1500352 - Force layout before finding screenshot r?jaws

If switching from a view that didn't load the extension list
binding to the themes view the screenshot wouldn't be found
on Windows. Force a layout if the screenshot isn't found
to load the binding.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/66b05bf76375
Force layout before finding screenshot r=jaws

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/66b05bf76375

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Does this need an uplift request?

Comment 8

[Mark Striemer [:mstriemer]]

I found out today UX would like to postpone theme previews, so this won't need an uplift.

Comment 9

[Mark Striemer [:mstriemer]]

Comment on attachment 9022392 [details]
Bug 1500352 - Force layout before finding screenshot r?jaws

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1495713

User impact if declined: Theme previews don't appear on Windows in certain cases.

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: No

Needs manual test from QE?: Yes

If yes, steps to reproduce: 0. Make sure you don't have any extensions installed.
1. Install a theme.
2. Go to about:addons.
3. Go to Plugins, then Themes
  * Preview is shown
4. Go to Extensions, then Themes

The preview should still be shown, previously it would not be shown.

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): It just forces a layout before setting the screenshot.

String changes made/needed:

Comment 10

[Mark Striemer [:mstriemer]]

Comment on attachment 9022392 [details]
Bug 1500352 - Force layout before finding screenshot r?jaws

Removing beta request. I've got a patch that is removing this code to fix a different issue (and also fixes this).

Comment 11

[Daniel Cicas [:dcicas], Release QA]

I reproduced this issue using Fx 64.0a1, build ID: 20181018220439, on Windows 10 x64 and Ubuntu 18.04 x64.

I can confirm this issue is fixed, I verified using Fx 65.0b9, build ID: 20190107180200, on Windows 10 x64 and Ubuntu 18.04 LTS.