1500354 - [remote-dbg-next] Add favicons for about:debugging and about:devtools-toolbox

Status: RESOLVED FIXED

(DevTools :: about:debugging, enhancement, P1)

Description

[Julian Descottes [:jdescottes]]

Most user facing about:pages have a favicon defined (about:preferences, about:addons). We could define a favicon for about:debugging as well to make it easier to identify in the tab list.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: image.png

Comment 2

[Julian Descottes [:jdescottes]]

filter on remote-debugging-next-move-m3-to-m2

Comment 3

[Julian Descottes [:jdescottes]]

filter on remote-debugging-next-move-m3-to-m2

Comment 4

[Julian Descottes [:jdescottes]]

filter on remote-debugging-next-move-m3-to-m2

Comment 6

[Victoria Wang [:victoria]]

How about the wrench icon? https://design.firefox.com/icons/viewer/#developer

This is in the category of DevTools, and the wrench kind of represents debugging

Comment 7

[Julian Descottes [:jdescottes]]

Attachment: image.png

Screenshot with:

• wrench icon for about:debugging
• window icon for about:devtools-toolbox (temporary)
• custom title for about:devtools-toolbox

For the about:devtools-toolbox title the pattern is:

• for local targets: Toolbox - {target type} / {target title}
• for remote targets: Toolbox ({connection type}) - {target type} / {target title}
• for error page: Toolbox - error occurred

I think it's nice to have the connection type, but for "Network" that also means you are less likely to see the target type and title. Maybe remote targets should be Toolbox - {target type} / {target title} ({connection type}) instead?

Comment 8

[Julian Descottes [:jdescottes]]

Sorry to bother you again for this :) The Wrench icon looks good for about:debugging, I'm now looking for an icon for the "tabs" we open to debug targets. I am using the "window" icon in the screenshot above, because it kind of looks like a toolbox. Do you have any suggestion? Should we create a new icon?

Comment 9

[Julian Descottes [:jdescottes]]

Attachment: Bug 1500354 - Use wrench favicon for about:debugging

Comment 10

[Julian Descottes [:jdescottes]]

Attachment: Bug 1500354 - Use window favicon for about:devtools-toolbox

Depends on D28963

Comment 11

[Julian Descottes [:jdescottes]]

Attachment: Bug 1500354 - Add title to about:devtools-toolbox tabs

Depends on D28964

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e9e6acc1b0cc
Use wrench favicon for about:debugging r=ladybenko
https://hg.mozilla.org/integration/autoland/rev/dbb2526ae6eb
Use window favicon for about:devtools-toolbox r=ladybenko
https://hg.mozilla.org/integration/autoland/rev/6596c844c27e
Add title to about:devtools-toolbox tabs r=ladybenko

Comment 13

[Narcis Beleuzu [:NarcisB]]

Backed out for dt failures on browser_aboutdebugging_serviceworker_timeout.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/31c0dbb08e0c5bc4e9dbc46bca1c7d44bc9331e6
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=243448540&repo=autoland&lineNumber=2186

Comment 14

[Julian Descottes [:jdescottes]]

Sorry about this!

This test should close the about:devtools-toolbox tab that is opened but instead it just calls toolbox.destroy.
Therefore we still have a tab now named "Toolbox - Worker / https://[...]" listed in the tabs.
And we are waiting until there are no targets in about:debugging that match the worker's script URL to detect that the worker has been removed. But since the about:devtools-toolbox tab is still there, and has the worker's URL in its title, it confuses our findDebugTargetByText helper.

Some tests were also waiting for "about:devtools-toolbox" to appear in the list of targets. I updated them to rely on the new title.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e23349259529
Use wrench favicon for about:debugging r=ladybenko
https://hg.mozilla.org/integration/autoland/rev/635651230a22
Use window favicon for about:devtools-toolbox r=ladybenko
https://hg.mozilla.org/integration/autoland/rev/0471422dc4af
Add title to about:devtools-toolbox tabs r=ladybenko

Comment 16

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/e23349259529
https://hg.mozilla.org/mozilla-central/rev/635651230a22
https://hg.mozilla.org/mozilla-central/rev/0471422dc4af

Comment 17

[Victoria Wang [:victoria]]

(Sorry I hadn't responded to the need info sooner -- the window icon does seem good for now :))