150036 - Message cancelling doesn't work

Status: VERIFIED FIXED

(MailNews Core :: Networking: NNTP, defect)

Description

[Dmitry]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.1a) Gecko/20020607
BuildID:    2002060704

After updating build from 20020601 to 20020607 "cancel message" function stopped
working. Key *del* does nothing and the option in context menu is disabled for
about 1 second. After it is selected nothing happens.

Reproducible: Always
Steps to Reproduce:
1. Just try to cancel any messege 
2.
3.

Comment 1

[Boris 'pi' Piwinger]

This is also true in Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.1a)
Gecko/20020610. Cancel is very important -> MAJOR. IIRC it is alos a GNKSA
requirement.

There must be more reports, which I cannot find -> DUPEME

pi

Comment 2

[[e-mail] (gone - use [e-mail] instead)]

*** Bug 151573 has been marked as a duplicate of this bug. ***

Comment 3

[jay garcia]

CONFIRMED, Win98SE 2002061308

Comment 4

[Boris 'pi' Piwinger]

It used to work. Can someone track down when exactly it started to fail? The
reporter said 20020601 worked and 20020607 failed. Maybe we can see which patch
causes this problem.

pi

Comment 5

[[e-mail] (gone - use [e-mail] instead)]

Any JS errors on the console?

Comment 6

[jay garcia]

Stephen: JS Console here shows:

Error: gContextMenu has no properties

Comment 7

[[e-mail] (gone - use [e-mail] instead)]

Over to sean su, for now to investigate if this is fallot from bug 137141 (fixed
on 6/5/2002 trunk).

Comment 8

[[e-mail] (gone - use [e-mail] instead)]

Sean, can you take a look at this, when you have a moment.  See my previous
comments.  Thanks.

Comment 9

[Boris 'pi' Piwinger]

I have nothing in the JavaScript console.

(Removing DUPEME)

pi

Comment 10

[Frederic Bezies]

Confirming this bug.

Here is the error message in JS console :

Error: [Exception... "Component returned failure code: 0x80004001
(NS_ERROR_NOT_IMPLEMENTED) [nsIEditorShell.GetSelectedOrParentTableElement]" 
nsresult: "0x80004001 (NS_ERROR_NOT_IMPLEMENTED)"  location: "JS frame ::
chrome://editor/content/editor.js :: goUpdateTableMenuItems :: line 2459"  data: no]
Source File: chrome://editor/content/editor.js
Line: 2459

Hope it helps ;-)

Using trunk build 2002062008 - WindowsXP.

Comment 11

[Frederic Bezies]

I don't want to spam this bug, but I hope this bug I nominate in list for 153207
(make 1.1b not suck) should be quickly fixed.

It broke an important tool in mailnews...

Sorry for annoyance related to this comment. It would be the last one on this
bug from me (until fixing :-)

Comment 12

[Frederic Bezies]

*** Bug 156033 has been marked as a duplicate of this bug. ***

Comment 13

[[e-mail] (gone - use [e-mail] instead)]

*** Bug 156896 has been marked as a duplicate of this bug. ***

Comment 14

[Rainer Bielefeld]

please have a look on bug 153835, see the information listed there and decide
weather it should be marked as DPU or DEPENDS ON this bug

Comment 15

[[e-mail] (gone - use [e-mail] instead)]

*** Bug 153835 has been marked as a duplicate of this bug. ***

Comment 16

[[e-mail] (gone - use [e-mail] instead)]

Here's a workaround, which may help explain why this bug is occuring in the 1st
place:

Steps to reproduce:
1. Go to one of your news accounts
2. Select a random message and right-click on it
3. Notice the 'Cancel Message' option is greyed out
4. Go the the 'Copy To' or 'Label' option and let the sub-menu appear
5. Notice 'Cancel Message' is no longer greyed out

Thanks to Devin from bug 153835 for the steps.

Comment 17

[Garth Wallace]

Even if you use the "workaround" to activate the Cancel Message menu entry, it
still doesn't do anything of you select it.

Comment 18

[Rene ALBERT]

Under win 95 OSR2, no by-pass for this bug with Moz 1.1b as of 07/19 ...
Cancel remains greyed whatever you do.

Comment 19

[Rainer Bielefeld]

The "workaround" does not work for me with 
Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.1b) Gecko/20020722
:-(

Comment 20

[Devin Henderson]

confirming that the workaround still works for me and that clicking it once it
is active still does nothing. winXP, moz 1.1b build 2002072408

Comment 21

[Rene ALBERT]

The bug is still ther with 1.1b 20020721 (Win 95 OSR2)

Comment 22

[Frederic Bezies]

Since 1.1 is going to be branched 2th of august, this bug has to be fixed ! :-/

It would be a shame if it stays in 1.1 final ! :-/

Comment 23

[Christian :Biesinger (don't email me, ping me on IRC)]

nominating for next netscape release because this really should be fixed.
removing bug 153835 from dependencies because it's now a dup of this one
adding useless-ui keyword because it is

my short look at the mailnews/ checkins between june 1 and june 7 did not really
show any likely suspects for causing this regression... and I ftp.m.o doesn't
have the builds from that dates for further checking.

Comment 24

[Rainer Bielefeld]

This very vixible, annoying bug should have
- a priority
- a target milestone

Comment 25

[Christian :Biesinger (don't email me, ping me on IRC)]

how does a priority and target milestone change anything?


see, the owner is on vacation. most likely nothing will happen until he gets
back or someone else steps up to fix it.

Comment 26

[Frederic Bezies]

Well, why not setting this bug fix for 1.2alpha ? It can't be made for 1.1, and
this is a /bad/ news for a public test release, isn't it ?

Let's wait until owner's return.

Comment 27

[Christian :Biesinger (don't email me, ping me on IRC)]

Frederic, you are contradicting yourself. 1.2 will be frozen September 3, and I
suppose released not more than a week after that.
Therefore, the owner of this bug will not return until after 1.2 is released,
and can therefore not fix this bug for that release.

and... what do you mean by "setting this bug fix for 1.2alpha" anyway? the
target milestone field should only be changed by the assignee.

Comment 28

[Frederic Bezies]

Well, I am a little tired.

On roadmap, 1.2a is going to be freezed for sept. 4th, releasing sept. 6th (well
for what I can see on trunk build, I think date would be delayed at least for
one week :-)

Well, I hope this bug is going to be listed for future "make 1.2beta not suck"
tracking bug :-)

I wanted to mean that it would be great to set target milestone fixing for this
bug to be 1.2alpha.

Well, after looking at roadmap, 1.2beta would be great ! :-)

I hope - and prey - this bug will be dead for 1.2 final release !

I am very upset not to have a working cancel function in news, and more upset
not to be a coder ! :-)

Comment 29

[[e-mail] (gone - use [e-mail] instead)]

*** Bug 166777 has been marked as a duplicate of this bug. ***

Comment 30

[(not reading, please use [e-mail] instead)]

taking

Comment 31

[(not reading, please use [e-mail] instead)]

Attachment: patch

Comment 32

[David :Bienvenu]

Comment on attachment 98139 [details] [diff] [review]
patch

sr=bienvenu

Comment 33

[(not reading, please use [e-mail] instead)]

david and I figured out that this broken by
http://bugzilla.mozilla.org/show_bug.cgi?id=138018

canDeleteMessages is false for news (which is correct, because we can't move
messages, or do toolbar delete)

but a long time ago I made edit | delete be edit | cancel

we probably need a new command cmd_cancel so we don't have these problem.

but this is safer and simpler for 1.2

Comment 34

[Asa Dotzler [:asa]]

Comment on attachment 98139 [details] [diff] [review]
patch

a=asa (on behalf of drivers) for checkin to 1.2a. Thanks for the regression
fix.

Comment 35

[varada]

Comment on attachment 98139 [details] [diff] [review]
patch

looks good to me. r=varada

Comment 36

[(not reading, please use [e-mail] instead)]

fixed.  I've logged http://bugzilla.mozilla.org/show_bug.cgi?id=167137 about 
adding cmd_cancel and cleaning up the code.

Comment 37

[[e-mail] (gone - use [e-mail] instead)]

I tried the following:

Cancel in the context menu, Edit | Cancel Message and the Del key.

Verified FIXED with builds:

Mac OS X 10.1.5 - 2002-09-09-08
Mac OS 9.2 - 2002-09-09-08
RedHat 7.3 - 2002-09-09-08
Windows 2K - 2002-09-09-08

Comment 38

[Josh Birnbaum]

*** Bug 174669 has been marked as a duplicate of this bug. ***

Comment 39

[Steve Frost]

*** Bug 178670 has been marked as a duplicate of this bug. ***

Comment 40

[Frederic Bezies]

*** Bug 178669 has been marked as a duplicate of this bug. ***