Spell check button disappeared on compose window - 64a

RESOLVED FIXED in Thunderbird 64.0

Status

defect
RESOLVED FIXED
9 months ago
9 months ago

People

(Reporter: marcoagpinto, Assigned: jorgk)

Tracking

Thunderbird 64.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

[11:29] <marcoagpinto> mkmelin: https://addons.cdn.mozilla.net/user-media/previews/full/206/206501.png?modified=1533284509
[11:29] <marcoagpinto> :)
[11:30] <marcoagpinto> here is a screenshot of TB 60
[11:30] <marcoagpinto> in 64a (65?) the combobox vanished
[11:34] <@mkmelin> ah yes, no language selection box on the toolbar anymore. I see that. Can you file a bug?
regression?
Flags: needinfo?(jorgk)
Yes, it's gone :-(

Alice, can you please find the regression for us? Thanks in advance.
Flags: needinfo?(jorgk) → needinfo?(alice0775)
Summary: No language selection box on the toolbar any more - 64a → Spell check button disappeared on compose window - 64a
Thanks, Alice. I see what happened. That bug removed "@mozilla.org/spellchecker;1" which we test here:
https://searchfox.org/comm-central/rev/f9a9b8d71d4898fef36bc6eea2dfde0e0e56ff35/editor/ui/composer/content/editor.js#2491

If it's not there, we hide the button here:
https://searchfox.org/comm-central/rev/f9a9b8d71d4898fef36bc6eea2dfde0e0e56ff35/editor/ui/composer/content/editor.js#2522

:-(

So that happened in mid-September and one month later someone finds the issue :-(
Assignee: nobody → jorgk
Attachment #9018660 - Flags: review?(acelists)
Comment on attachment 9018660 [details] [diff] [review]
1500372-spell-checker-installed.patch

Review of attachment 9018660 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.
Attachment #9018660 - Flags: review?(acelists) → review+
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
OS: Unspecified → All
Hardware: Unspecified → All
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/941b876fbeb8
Port bug 1491569: Assume that spellchecker is always installed. r=aceman
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Marco, thanks for reporting, keep the bugs coming!
Target Milestone: --- → Thunderbird 64.0
You need to log in before you can comment on or make changes to this bug.