Closed
Bug 1500372
Opened 6 years ago
Closed 6 years ago
Spell check button disappeared on compose window - 64a
Categories
(Thunderbird :: Message Compose Window, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 64.0
People
(Reporter: marcoagpinto, Assigned: jorgk-bmo)
Details
Attachments
(1 file)
|
912 bytes,
patch
|
aceman
:
review+
|
Details | Diff | Splinter Review |
[11:29] <marcoagpinto> mkmelin: https://addons.cdn.mozilla.net/user-media/previews/full/206/206501.png?modified=1533284509
[11:29] <marcoagpinto> :)
[11:30] <marcoagpinto> here is a screenshot of TB 60
[11:30] <marcoagpinto> in 64a (65?) the combobox vanished
[11:34] <@mkmelin> ah yes, no language selection box on the toolbar anymore. I see that. Can you file a bug?
|
Assignee | |
Comment 2•6 years ago
|
||
Yes, it's gone :-(
Alice, can you please find the regression for us? Thanks in advance.
Flags: needinfo?(jorgk) → needinfo?(alice0775)
|
|
Assignee | |
Updated•6 years ago
|
Summary: No language selection box on the toolbar any more - 64a → Spell check button disappeared on compose window - 64a
|
||
Comment 3•6 years ago
|
||
Regression window:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=d01e5283a6d7ea8c7b5643f314f92ce48d71936c&tochange=13445f1444562f2e4ed891c91c68eb26d2e3c744
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=5d14d1e9f74d7cac00bdefbda29244d586645682&tochange=7ed950e60f3c1f8a47c117c04124d31e94a66e32
Suspect: 1cef5144d067 Ehsan Akhgari — Bug 1491569 - Remove the XPCOM registration for mozSpellChecker; r=smaug
Flags: needinfo?(alice0775)
|
|
Assignee | |
Comment 4•6 years ago
|
||
Thanks, Alice. I see what happened. That bug removed "@mozilla.org/spellchecker;1" which we test here:
https://searchfox.org/comm-central/rev/f9a9b8d71d4898fef36bc6eea2dfde0e0e56ff35/editor/ui/composer/content/editor.js#2491
If it's not there, we hide the button here:
https://searchfox.org/comm-central/rev/f9a9b8d71d4898fef36bc6eea2dfde0e0e56ff35/editor/ui/composer/content/editor.js#2522
:-(
So that happened in mid-September and one month later someone finds the issue :-(
|
|
Assignee | |
Comment 5•6 years ago
|
||
Assignee: nobody → jorgk
Attachment #9018660 -
Flags: review?(acelists)
Comment on attachment 9018660 [details] [diff] [review]
1500372-spell-checker-installed.patch
Review of attachment 9018660 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks.
Attachment #9018660 -
Flags: review?(acelists) → review+
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
OS: Unspecified → All
Hardware: Unspecified → All
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/941b876fbeb8
Port bug 1491569: Assume that spellchecker is always installed. r=aceman
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 8•6 years ago
|
||
Marco, thanks for reporting, keep the bugs coming!
Target Milestone: --- → Thunderbird 64.0
You need to log in
before you can comment on or make changes to this bug.
Description
•