1500395 - [remote-dbg-next] migrate aboutdebugging test: browser_service_workers_status.js

Status: RESOLVED FIXED

(DevTools :: about:debugging, enhancement, P1)

Description

[Julian Descottes [:jdescottes]]

Migrate https://searchfox.org/mozilla-central/source/devtools/client/aboutdebugging/test/browser_service_workers_status.js to the new about:debugging

Comment 1

[Julian Descottes [:jdescottes]]

filter on remote-debugging-next-move-m3-to-m2

Comment 2

[Julian Descottes [:jdescottes]]

filter on remote-debugging-next-move-m3-to-m2

Comment 3

[Julian Descottes [:jdescottes]]

filter on remote-debugging-next-move-m3-to-m2

Comment 4

[Julian Descottes [:jdescottes]]

You can have a look at the following documentation for some tips on how to migrate tests: https://gist.github.com/juliandescottes/fecc426ac84600357259bf513cea744c

Comment 5

[Julian Descottes [:jdescottes]]

In its current shape the existing test in about:debugging is not testing anything interesting comparing to our existing tests. It simply waits for a serviceworker to reach the stopped state, but we already do that as a prerequisite to most of our service worker tests.

To design a stable test here we would need to be able to drive the "registering", "starting" and "stopped" phases of the service worker from the test page. I will try to do this, but if it seems too complicated let's move this to P3 or outside of m2 directly since it's not a gap.

Comment 6

[Julian Descottes [:jdescottes]]

Attachment: Bug 1500395 - Fix react warning for ServiceWorkerAction component;r=daisuke

Depends on D17555

Not necessary, but one less react warning in the logs :)

Comment 7

[Julian Descottes [:jdescottes]]

Attachment: Bug 1500395 - Remove incorrect mentions about push in empty sw;r=daisuke

Depends on D17629
Small leftover from previous bugs

Comment 8

[Julian Descottes [:jdescottes]]

Attachment: Bug 1500395 - Migrate service worker status test to new about:debugging;r=daisuke

Depends on D17630
I am not mentioning the original test in the test file because they are not similar.
Original test was not actually testing anything interesting for us.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3b9416e476b7
Fix react warning for ServiceWorkerAction component;r=daisuke
https://hg.mozilla.org/integration/autoland/rev/8c7f41867ac7
Remove incorrect mentions about push in empty sw;r=daisuke
https://hg.mozilla.org/integration/autoland/rev/d2e4d4ff466b
Migrate service worker status test to new about:debugging;r=daisuke

Comment 11

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/3b9416e476b7
https://hg.mozilla.org/mozilla-central/rev/8c7f41867ac7
https://hg.mozilla.org/mozilla-central/rev/d2e4d4ff466b