Closed Bug 1500399 Opened 6 years ago Closed 6 years ago

Sceenshot of the entire page is actually of the viewport

Categories

(DevTools :: General, defect, P1)

Product:
DevTools
Component:
General
Version:
64 Branch
Platform:
All
Other
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED WORKSFORME

People

(Reporter: g.rossolini, Unassigned)

References

(
URL
)

Details

(Keywords: regression) 

:: Developer Documentation Request

      Request Type: Correction
     Gecko Version: 64 Branch
 Technical Contact: 

:: Details

It used to be that the screenshot feature could capture the entire page, as the documentation says. But it appears it is no longer the case.
I am not sure when that changed. On Oct 2nd I was still able to screenshot a long page with scroll into a single JPEG at least worth 10 viewports), but not now with 64.0b1 (64 bits).
I have no idea if this is a bug in Firefox, or if it was an intended change but the documentation was not updated.
Confirmed. Harald, is this a bug or an intended change?
Flags: needinfo?(hkirschner)
This sounds like a regression.

ni? Yulia for triage input.
Component: Developer Tools → General
Flags: needinfo?(hkirschner) → needinfo?(ystartsev)
Keywords: regression
Product: Developer Documentation → DevTools
Version: unspecified → 64 Branch
This does appear to be a regression in 64 we want to track. I tested in both 62 and 63 and it worked there.
Also worth noting, in 64, 2 other things are missing: 
- the camera shutter sound does not play (it does it previous versions)
- the download icon in Firefox's toolbar does not animate (it also does in previous versions)

[Tracking Requested - why for this release]:
This is a very well known feature of DevTools that has set us apart from our competition in the past, we need to make sure it continues to work. So we will need to uplift the fix once we find it.
Status: UNCONFIRMED → NEW
status-firefox64: --- → affected
tracking-firefox64: --- → ?
Ever confirmed: true
Priority: -- → P1
Yeah this looks like a regression. I will be away this week, I can look into it early next week if there is no movement on it.
Flags: needinfo?(ystartsev)
Sorry, this actually works for me in 64. I was being stupid and people reminded me that a fullpage screenshot is only useful when it's the document that has the scrollbar.
When I tested on 64 (which is the version I use right now), I tested on this page (bugzilla). However bugzilla has a fixed header, and scrollable wrapper below that. So the page is actually not longer than the viewport, it just contains a scrollable div.
For these types of pages, the --fullpage screenshot feature doesn't do anything special, and it never did.

Could you test again on this test URL please:
data:text/html,<meta charset=utf8><body style="height: 200vh;display:flex;align-items: end;"><h1>Hello</h1></body>
if the screenshot contains the word Hello, then the fullpage feature still works.
Flags: needinfo?(g.rossolini)
I usually take screenshots of nodes, rather than the whole document. I can't be 100% certain it used to work, but I'm fairly sure that was the case.
Does it behave differently between whole page or just a node of the tree? Does the scroll need to be of that element, or airways on the Document?
In any event, I won't have access to that computer for another week.
Flags: needinfo?(g.rossolini)
(In reply to g.rossolini from comment #6)
> I usually take screenshots of nodes, rather than the whole document. I can't
> be 100% certain it used to work, but I'm fairly sure that was the case.
> Does it behave differently between whole page or just a node of the tree?
Yes it does, taking the screenshot of a node only takes that node and ignores the --fullpage argument which only works for the entire document.
> Does the scroll need to be of that element, or airways on the Document?
> In any event, I won't have access to that computer for another week.
I'm going to close this as WORKSFORME for now, feel free to re-open when you get access to your computer again.
Thanks!
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WORKSFORME
(In reply to Patrick Brosset <:pbro> from comment #7)
> Yes it does, taking the screenshot of a node only takes that node and
> ignores the --fullpage argument which only works for the entire document.
I am on that computer again, and it works fine with v64.0b6 (64 bits). I can again screenshot a node that has a long scroll and get a long image from it. No changes to the HTML were made.
You need to log in before you can comment on or make changes to this bug.