150044 - UTF16 converters have problem

Status: VERIFIED FIXED

(Core :: Internationalization, defect)

Description

[Frank Tang]

this bug is found when we do germany top sites testing 

http://www.skandale24.de is encoded in UTF16-BE and we conver it wrong.
see 
http://bugscape.mcom.com/show_bug.cgi?id=16047 for details

subject : www.skandale24.de: site not displayed - only after reload

Netscape 7.0  (Gecko 1.0rc2/20020512 Netscape/7.0b1)

- open http://www.skandale24.de
- you'll be redirected to http://www.skandale24.com/home.htm

***Result:
Site is not displayed, although the whole source code is transfered.
After reload the content is displayed.

Note: the coding is changed to UTF-16LE

yokoyama introduce a none member function and pass in the member variable in.
However, he does not pass it in as referece

the fix is easy, pass in mState and mData as reference instead of pass in as
value.

Comment 1

[Frank Tang]

adt1 due to business issue. see the bugscape bug for detail

Comment 2

[Frank Tang]

Attachment: fix, pass by reference and also change the var name from mData/mState to aData/aState since they are not member data in the function

Comment 3

[Frank Tang]

assign

Comment 4

[Frank Tang]

cc

Comment 5

[Roy Yokoyama]

Comment on attachment 86855 [details] [diff] [review]
fix, pass by reference and also change the var name from mData/mState to aData/aState since they are not member data in the function

/r=yokoyama

Comment 6

[kinmoz]

Comment on attachment 86855 [details] [diff] [review]
fix, pass by reference and also change the var name from mData/mState to aData/aState since they are not member data in the function

sr=[e-mail]

Though it just seems odd to me to have some return parameters be references and
some be pointers. Why not make them all consistent and be pointers?

Comment 7

[Frank Tang]

land into trunk.

Comment 8

[Frank Tang]

can some qa verified this on the trunk. Untill that happen I won't be able to
ask adt to approve for branch landing. Mark it as VERIFIED once you verified on
the trunk.

Comment 9

[Doron Rosenberg (IBM)]

verified on linux and win2k.

Comment 10

[Jaime Rodriguez, Jr.]

ylong - pls verify this on the trunk, so that we can get it into the branch. thanks!

Comment 11

[Yuying Long]

Verified fixed on 06-18 trunk build / WinXP-SC - the page loads fine and the
charset in marked as 

Comment 12

[Judson Valeski]

please checkin to the 1.0.1 branch. once there, remove the "mozilla1.0.1+"
keyword and add the "fixed1.0.1" keyword.

Comment 13

[Paul Wyskoczka]

Marking adt1.0.1+ on behalf of the adt for checkin to the 1.0 branch.  Please
get drivers approval before checking in.

Comment 14

[Yuying Long]

Verified fixed on 06-20 1.0.0 branch build on WinXP-SC.