Closed Bug 1500447 Opened Last year Closed Last year

[mozlint] Unix formatter fails when there is a yamllint issue

Categories

(Firefox Build System :: Lint and Formatting, defect)

defect
Not set

Tracking

(firefox64 fixed)

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: ahal, Assigned: ahal)

Details

Attachments

(1 file)

This is happening because the yamllint integration is passing in strings to the lineno and column attributes and the unix formatter is assuming they are integers.

Let's fix this by casting these two things to int first (so both integers or strings are valid).
This also updates the test for string inputs.
Pushed by ahalberstadt@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/96304d13c406
[mozlint] Make sure lineno and column are always int (if present), r=rwood
https://hg.mozilla.org/mozilla-central/rev/96304d13c406
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.