Closed Bug 1500455 Opened 2 years ago Closed 2 years ago

Let's use cookieBehavior = 4 in beta by default

Categories

(Core :: DOM: Security, enhancement)

Product:
Core
Component:
DOM: Security
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla65
Tracking Flags:
Tracking Status
firefox64 --- fixed
firefox65 --- fixed

People

(Reporter: baku, Assigned: baku, NeedInfo)

Details

(Whiteboard: [domsecurity-backlog1] [domsecurity-active])

Attachments

(1 file)

pref.patch
1.25 KB, patch
ehsan
: review+
RyanVM
: approval-mozilla-beta+
Details | Diff | Splinter Review 
This has been discussed during the Default Cookie Restrictions Meeting.
We would like to have 12 weeks of testing in beta in order to see if we have regressions and to have enough time to fix them.
Assignee: nobody → amarchesini
Status: NEW → ASSIGNED
Whiteboard: [domsecurity-backlog1] [domsecurity-active]
Attached patch pref.patch — — Splinter Review
Attachment #9019439 - Flags: review?(ehsan)
Comment on attachment 9019439 [details] [diff] [review]
pref.patch

r=me.  Please request uplift too.
Attachment #9019439 - Flags: review?(ehsan) → review+
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/006df234545b
Let's use cookieBehavior = 4 in beta by default, r=ehsan
Comment on attachment 9019439 [details] [diff] [review]
pref.patch

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: n/a

User impact if declined: We want to have more data about cookieBehavior 4 and we would like to use the beta population.

Is this code covered by automated tests?: Yes

Has the fix been verified in Nightly?: Yes

Needs manual test from QE?: No

If yes, steps to reproduce: n/a

List of other uplifts needed: n/a

Risk to taking this patch: Medium

Why is the change risky/not risky? (and alternatives if risky): Medium because the purpose of this patch is to collect data: we want to collect regressions.

String changes made/needed: n/a
Attachment #9019439 - Flags: approval-mozilla-beta?
Peter, maybe you want to add something in the beta uplift request? Thanks
Flags: needinfo?(pdolanjski)
https://hg.mozilla.org/mozilla-central/rev/006df234545b
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Just to be clear, we flip EARLY_BETA_OR_EARLIER roughly halfway through the Beta cycle. For 64, it'll likely be after we ship b7 on 6-Nov.
Comment on attachment 9019439 [details] [diff] [review]
pref.patch

Approved for 64.0b4. I'm also updating the commit message for the uplift to make clear that this is only being changed for early betas. I think that's an important point of clarification and the commit message for m-c is misleading.
Attachment #9019439 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.