1500469 - Don't require /shared/css/properties-db.js in the inspector client

Status: RESOLVED FIXED

(DevTools :: Inspector, enhancement, P3)

Description

[Gabriel Luong [:gl] (ΦωΦ)]

Currently, requiring /shared/css/properties-db.js accounts for around 9ms because it is loading devtools/shared/css/generated/properties-db which is not actually utilized on the client. 

This bug is to remove all the constants from properties-db, which are actually needed by output-parser and other client files. That way we don't ever need to require properties-db in the client side and it forces the separation of concerns between these css constant and the css properties-db in this file. 

We moved any constants that are required in multiple files to a new file shared/css/constants.js and inlines ANGLE_TAKING_FUNCTION, BEZIER_KEYWORDS, COLOR_TAKING_FUNCTIONS, BASIC_SHAPE_FUNCTIONS into output-parser.js since it is not used anywhere else.

Comment 1

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: 1500469.patch [1.0]

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4d6e6d7e58ba
Don't require /shared/css/properties-db.js in the inspector client. r=mtigley

Comment 3

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/4d6e6d7e58ba