Closed Bug 1500469 Opened Last year Closed Last year

Don't require /shared/css/properties-db.js in the inspector client

Categories

(DevTools :: Inspector, enhancement, P3)

enhancement

Tracking

(firefox64 fixed)

RESOLVED FIXED
Firefox 64
Tracking Status
firefox64 --- fixed

People

(Reporter: gl, Assigned: gl)

Details

Attachments

(1 file)

Currently, requiring /shared/css/properties-db.js accounts for around 9ms because it is loading devtools/shared/css/generated/properties-db which is not actually utilized on the client. 

This bug is to remove all the constants from properties-db, which are actually needed by output-parser and other client files. That way we don't ever need to require properties-db in the client side and it forces the separation of concerns between these css constant and the css properties-db in this file. 

We moved any constants that are required in multiple files to a new file shared/css/constants.js and inlines ANGLE_TAKING_FUNCTION, BEZIER_KEYWORDS, COLOR_TAKING_FUNCTIONS, BASIC_SHAPE_FUNCTIONS into output-parser.js since it is not used anywhere else.
Attachment #9018688 - Flags: review?(mtigley)
Attachment #9018688 - Flags: review?(mtigley) → review+
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4d6e6d7e58ba
Don't require /shared/css/properties-db.js in the inspector client. r=mtigley
https://hg.mozilla.org/mozilla-central/rev/4d6e6d7e58ba
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
You need to log in before you can comment on or make changes to this bug.