Closed Bug 1500474 Opened 2 years ago Closed 2 years ago

Rename "webcompat-reporter" directory to "report-site-issue"

Categories

(Web Compatibility :: Tooling & Investigations, enhancement, P3)

enhancement

Tracking

(firefox68 fixed)

RESOLVED FIXED
Tracking Status
firefox68 --- fixed

People

(Reporter: miketaylr, Assigned: marian.meireles)

References

Details

Attachments

(1 file, 1 obsolete file)

Just to reduce confusion when we talk about our 2 systems addons, let's rename the "webcompat-reporter" to "report-site-issue".

(more than a few people have been confused at the difference between the "webcompat" and "webcompat-reporter" addons)
Flags: needinfo?(miket)
I'm guessing we'll also be moving over any localization string-bundles to new directories, and renaming the about:config prefs as well, yes?

(In reply to Thomas Wisniewski [:twisniewski] (PTO Dec 24-26, 31-2nd) from comment #2)

I'm guessing we'll also be moving over any localization string-bundles to
new directories, and renaming the about:config prefs as well, yes?

Yeah, probably. I guess we want to rename everything here: https://searchfox.org/mozilla-central/search?q=webcompat-reporter

Something you want to work on Mariana?

Flags: needinfo?(marian.meireles)

(In reply to Mike Taylor [:miketaylr] from comment #4)

Something you want to work on Mariana?

Yeah, sure! :)

Flags: needinfo?(marian.meireles)
Assignee: nobody → marian.meireles
Attachment #9039561 - Attachment is obsolete: true
Blocks: 1524523

This seems to have been granted review, is there a reason it hasn't landed yet?

Flags: needinfo?(miket)
Flags: needinfo?(marian.meireles)

Hm... I think we just forgot. :(

@Mariana, do you think you can re-base the patch? I think Tom's work on about:compat might have created some conflicts. Then let's get it landed!

Flags: needinfo?(miket)

This: https://phabricator.services.mozilla.com/D17890#change-r65ycskz7t2N was the only thing I had to change.

How do I proceed now? Should I ping florian and Pike again to review my work?

Flags: needinfo?(marian.meireles)

Nope, no need for a re-review, IMO.

Could you please squash that second fixup commit into the first?

Flags: needinfo?(marian.meireles)

Sorry for the delay.
I think it's finally correct!

Flags: needinfo?(marian.meireles) → needinfo?(miket)
Type: defect → enhancement
Flags: needinfo?(miket)
Flags: needinfo?(miket)

Tom, can you double check and help land this?

Flags: needinfo?(miket) → needinfo?(twisniewski)
Pushed by twisniewski@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ba4736a11504
Rename webcompat-reporter directory to report-site-issue r=florian,Pike
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Flags: needinfo?(twisniewski)
You need to log in before you can comment on or make changes to this bug.