1500538 - Find the media element from context menu event dispatched from video controls in GeckoView

Status: NEW

(GeckoView :: Media, enhancement, P2)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Basically, we'll need to do 

https://phabricator.services.mozilla.com/D9016

in

https://dxr.mozilla.org/mozilla-central/rev/c291143e24019097d087f9307e59b49facaf90cb/mobile/android/chrome/geckoview/GeckoViewContent.js#257-258

per

https://phabricator.services.mozilla.com/D9016#220915

What's the application to test GeckoView? How do I build it?

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Is the function being implemented correctly? I don't think it accounts <video><source src=></video>...

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Maybe I'm misunderstanding this bug, but doesn't feel like XBL implementation related.

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Never mind, I can see it checks currentSrc.

Comment 4

[Jan Henning [:JanH]]

In-tree, GeckoView is used for PWAs and custom tabs in Fennec, and there's also the GeckoView Example app that's accessible if you switch the build configuration in Android Studio (or run something like ./mach gradle geckoview_example:installLocalWithGeckoBinariesMinApi21Debug). Neither of those implements any real context menus, although you can still catch and check the event handling in GeckoViewContent.js itself.

For custom tabs, you can e.g. use something like this (https://github.com/walkingice/CustomTabsLauncher) if you don't know any other app that uses them, whereas for the Geckoview Example app you need to disable e10s from the three dot menu so you can debug GeckoViewContent.js from the WebIDE.

Comment 5

[David Bolter [:davidb] (NeedInfo me for attention)]

Tim do you want to take this bug? (Does comment 4 answer what you need?)

Comment 6

[Tim Guan-tin Chien [:timdream] (please needinfo)]

I don't have an Android environment with me, so it would be more efficient if someone else could do it.

Comment 7

[Chris Peterson [:cpeterson]]

Moving some media bugs to the new GeckoView::Media component.

Comment 8

[Chris Peterson [:cpeterson]]

Assigning this bug to Makoto. He will decide whether we need to prioritize it for 2022 H2.

Comment 9

[Chris Peterson [:cpeterson]]

Enhancements should have severity N/A.