Closed Bug 1500572 Opened 6 years ago Closed 6 years ago

Make it possible to implement marker payloads outside of profiler code

Categories

(Core :: Gecko Profiler, enhancement)

Product:
Core
Component:
Gecko Profiler
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1500635
Tracking Flags:
Tracking Status
firefox64 --- affected

People

(Reporter: mstange, Unassigned)

Details

When a component like graphics wants to add custom data to a profiler marker, a custom marker payload subclass needs to be created. At the moment, this subclass has to be defined in ProfilerMarkerPayload.h/.cpp because it makes use of the class SpliceableJSONWriter which is internal to profiler code. That's because SpliceableJSONWriter is declared in tools/profiler/core/ProfileJSONWriter.h, note the "core". If the definition of SpliceableJSONWriter was moved to tools/profiler/public, then such components could keep their subclasses in their code. Having the subclass in e.g. graphics code makes sense when the payload fields use internal types that you don't want to expose to profiler code.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.