1500609 - layout/generic/nsFrame.cpp:5223:20: error: use of undeclared identifier 'CachedFlexMeasuringReflow'

Status: RESOLVED FIXED

(Core :: Layout: Flexbox, enhancement)

Description

[Mats Palmgren (inactive)]

I'm adding a new file under layout/generic/ and it triggered
this build error, presumably because nsFrame.cpp/nsFlexContainerFrame.cpp
are no longer in the same compilation unit.

Comment 1

[Mats Palmgren (inactive)]

Attachment: wallpaper

I hacked this up temporarily to be able to build...
Does this look like a reasonable fix to you?

Comment 2

[Daniel Holbert [:dholbert]]

Sure, this seems fine.  Nit: might want to add "Mark" to the beginning of the funciton-name, for consistency & more-obvious-connection to MarkIntrinsicISizesDirty().  (The current name "FlexItemIntrinsicISizesDirty()" almost sounds like it could be a const boolean getter, rather than a function that actively does something.)

Maybe "MarkCachedFlexMeasurementsDirty", or something like that?

Comment 3

[Daniel Holbert [:dholbert]]

Totally makes sense that this would be a build failure, too -- looks like CachedFlexMeasuringReflow is declared inside of nsFlexContainerFrame.cpp (and nowhere else), so it's bogus to reference it from nsFrame.cpp.

  https://dxr.mozilla.org/mozilla-central/search?q=CachedFlexMeasuringReflow

Comment 4

[Mats Palmgren (inactive)]

Attachment: fix

Comment 5

[Mats Palmgren (inactive)]

Attachment: fix2

Apparently the above patch wasn't enough for non-DEBUG builds:

 0:19.87 In file included from layout/base/nsLayoutUtils.h:31:
 0:19.87 mozilla/ToString.h:26:10: error: invalid operands to binary expression ('std::ostringstream' (aka 'basic_ostringstream<char>') and 'const nsReflowStatus')
 0:19.87   stream << aValue;
 0:19.87   ~~~~~~ ^  ~~~~~~
 0:19.87 layout/generic/nsColumnSetFrame.cpp:746:22: note: in instantiation of function template specialization 'mozilla::ToString<nsReflowStatus>' requested here
 0:19.87                      ToString(aStatus).c_str());
 0:19.87                      ^

So I'll tag along this fix too...

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e1fde2f49f84
part 1 - Add a nsFlexContainerFrame method to remove cached data that depend on flex items' intrinsic isize (idempotent patch).  r=dholbert
https://hg.mozilla.org/integration/mozilla-inbound/rev/ea09443dac28
part 2 - Make the declaration of operator<< for nsReflowStatus unconditional since it's needed to build some COLUMN_SET_LOG expression in nsColumnSetFrame.cpp (idempotent patch).  r=me

Comment 7

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/e1fde2f49f84
https://hg.mozilla.org/mozilla-central/rev/ea09443dac28