Closed Bug 1500697 Opened 3 years ago Closed 3 years ago

Redirect SCDynamicStore APIs

Categories

(Core Graveyard :: Web Replay, enhancement)

enhancement
Not set
normal

Tracking

(firefox65 fixed)

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: bhackett1024, Assigned: bhackett1024)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
I've seen recording mismatches under nsOSXSystemProxySettings::Init, which I think are due to missing redirections on several SCDynamicStore methods called here and elsewhere in nsOSXSystemProxySettings.mm
Attachment #9018828 - Flags: review?(continuation)
Comment on attachment 9018828 [details] [diff] [review]
patch

Review of attachment 9018828 [details] [diff] [review]:
-----------------------------------------------------------------

I'm happy to rubber stamp this, but you might get a more useful review from somebody who actually knows about OSX stuff.
Attachment #9018828 - Flags: review?(continuation) → review+
https://hg.mozilla.org/mozilla-central/rev/101430a1be58
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.