1500741 - "encoding" parameter not parsed in custom search engine overrides

Status: VERIFIED FIXED

(WebExtensions :: Untriaged, defect)

Description

[jman]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:64.0) Gecko/20100101 Firefox/64.0

Steps to reproduce:

Using Firefox 64.0b2.

Tried to crate an extension with my own custom search engines, I've copied and pasted an official example from:

https://github.com/mdn/webextensions-examples/blob/master/discogs-search/manifest.json


Actual results:

Upon loading the extension I see this warning:

Reading manifest: Error processing chrome_settings_overrides.search_provider.encoding: An unexpected property was found in the WebExtension manifest.

The search engine works as expected, though.


Expected results:

No warnings. The "encoding" parameter should be correctly parsed and validated.

Comment 1

[Rares Doghi, Desktop QA]

Hi, Thanks for taking the time to report this issue, can you please provide the extension you created or a link to it so we can reproduce the issue as well, also can you please try this issue in the latest version of nightly you can find it here: https://nightly.mozilla.org.

Comment 2

[jman]

Attachment: discogs-search.zip

test case for the issue report

Comment 3

[jman]

Hello Rares,

thanks for your quick feedback!

The issue can be reproduced with latest nightly 65.0a1 (2018-10-23) (Linux 64-Bit)

Also, uploaded the extension to reproduce the issue.

Let me know if you need more info.

Comment 4

[Rares Doghi, Desktop QA]

Hi, Thanks for the Add-on, we can reproduce the issue as well in Firefox Nightly 65.0a1 (2018-10-23).

Comment 5

[Andrew Swan [:aswan]]

Mike, is this something we should support?

Comment 6

[Mike Kaply [:mkaply]]

Yes. It's easy to support.

Comment 7

[Mike Kaply [:mkaply]]

Attachment: Bug 1500741 - Support encoding for WebExtension engines.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/878c6403d4da
Support encoding for WebExtension engines. r=mixedpuppy

Comment 9

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/878c6403d4da

Comment 10

[jman]

Mike and all the team, thank you for taking care of this quickly!

Comment 11

[Rares Doghi, Desktop QA]

Hi, I can reproduce this issue in older versions of Firefox Nightly but I can't reproduce it in Nightly 65.0a1 (2018-11-07) Build ID 20181107095322 from (https://tools.taskcluster.net/index/gecko.v2.mozilla-central.latest.firefox/win64-opt). I will mark this issue accordingly.

Comment 12

[Shane Caraveo (:mixedpuppy)]

@mkpaly, I'm thinking I'd like to see a followup based on my last comment in phab.

queryCharset: new TextEncoder(searchProvider.encoding).encoding.toUpperCase();

null or undefined still produce utf-8.  This would at least prevent garbage in.

Comment 13

[Shane Caraveo (:mixedpuppy)]

sigh. forget it.

https://developer.mozilla.org/en-US/docs/Web/API/TextEncoder

It doesn't produce anything other than utf-8.

Comment 14

[Mike Kaply [:mkaply]]

https://github.com/mdn/browser-compat-data/pull/3257