Closed
Bug 1500747
Opened 6 years ago
Closed 6 years ago
Allow overriding extension building defaults in SeaMonkey via mozconfig
Categories
(SeaMonkey :: Build Config, enhancement)
SeaMonkey
Build Config
Tracking
(seamonkey2.60 wontfix, seamonkey2.63 fixed, seamonkey2.57esr fixed)
RESOLVED
FIXED
Future
People
(Reporter: frg, Assigned: frg)
References
Details
Attachments
(2 files)
|
3.87 KB,
patch
|
ewong
:
review+
iannbugzilla
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
|
1.55 KB,
patch
|
Details | Diff | Splinter Review |
Currently building DOMi, cZ and debugQA is disabled hard in confvars.sh because of bug 1231349. All three are being fixed for 2.57 so it should be at least possible to enable building them in local en-US builds without changing confvars.sh.
|
Assignee | |
Comment 1•6 years ago
|
||
Patch from Bill. Works fine for me. ewong could take a look in case I missed something. Makes it possible to use ac_add_options --enable-dominspector ac_add_options --enable-irc ac_add_options --enable-debugqa in the mozconfig file.
Assignee: nobody → frgrahl
Status: NEW → ASSIGNED
Attachment #9018874 -
Flags: review?(ewong)
Attachment #9018874 -
Flags: approval-comm-esr60?
|
|
Assignee | |
Comment 2•6 years ago
|
||
Additional fix to make disable-calendar work again. r+ from me.
Attachment #9018875 -
Flags: review+
Attachment #9018875 -
Flags: approval-comm-esr60?
|
|
Assignee | |
Comment 3•6 years ago
|
||
Comment on attachment 9018875 [details] [diff] [review] 1500747-mozconfig-calendar.patch Changes mailnews and not suite alone. This needs a separate bug.
Attachment #9018875 -
Flags: review+
Attachment #9018875 -
Flags: approval-comm-esr60?
|
|
||
Comment 4•6 years ago
|
||
Comment on attachment 9018874 [details] [diff] [review] 1500747-mozconfig-extensions.patch Review of attachment 9018874 [details] [diff] [review]: ----------------------------------------------------------------- r+ w/ query answered.. ::: suite/app.mozbuild @@ +14,5 @@ > + DIRS += ['/extensions/irc'] > + > +if CONFIG['MOZ_DOMINSPECTOR']: > + DIRS += ['/extensions/inspector'] > + is MOZ_DEBUGQA needed here? or is that done somewhere else?
|
|
||
Comment 5•6 years ago
|
||
Comment on attachment 9018874 [details] [diff] [review] 1500747-mozconfig-extensions.patch Review of attachment 9018874 [details] [diff] [review]: ----------------------------------------------------------------- I could've sworn I put a r+.
Attachment #9018874 -
Flags: review?(ewong) → review+
Pushed by frgrahl@gmx.net: https://hg.mozilla.org/comm-central/rev/b44fb89ce5da Allow overriding extension building defaults in SeaMonkey via mozconfig. r=ewong
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•6 years ago
|
status-seamonkey2.57esr:
--- → affected
status-seamonkey2.60:
--- → wontfix
Target Milestone: --- → Future
Comment on attachment 9018874 [details] [diff] [review] 1500747-mozconfig-extensions.patch a=me
Attachment #9018874 -
Flags: approval-comm-esr60? → approval-comm-esr60+
|
|
Assignee | |
Comment 8•6 years ago
|
||
https://hg.mozilla.org/releases/comm-esr60/rev/bd36350d005d7826db90acbb211884485f2e00b6
|
|
Assignee | |
Updated•5 years ago
|
status-seamonkey2.63:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•