Allow overriding extension building defaults in SeaMonkey via mozconfig

RESOLVED FIXED in Future

Status

enhancement
RESOLVED FIXED
9 months ago
7 months ago

People

(Reporter: frg, Assigned: frg)

Tracking

Trunk
Future

SeaMonkey Tracking Flags

(seamonkey2.57esr fixed, seamonkey2.60 wontfix, seamonkey2.63 fixed)

Details

Attachments

(2 attachments)

Currently building DOMi, cZ and debugQA is disabled hard in confvars.sh because of bug 1231349. All three are being fixed for 2.57 so it should be at least possible to enable building them in local en-US builds without changing confvars.sh.
Patch from Bill. Works fine for me. ewong could take a look in case I missed something.

Makes it possible to use
ac_add_options --enable-dominspector
ac_add_options --enable-irc
ac_add_options --enable-debugqa

in the mozconfig file.
Assignee: nobody → frgrahl
Status: NEW → ASSIGNED
Attachment #9018874 - Flags: review?(ewong)
Attachment #9018874 - Flags: approval-comm-esr60?
Additional fix to make disable-calendar work again. r+ from me.
Attachment #9018875 - Flags: review+
Attachment #9018875 - Flags: approval-comm-esr60?
Comment on attachment 9018875 [details] [diff] [review]
1500747-mozconfig-calendar.patch

Changes mailnews and not suite alone. This needs a separate bug.
Attachment #9018875 - Flags: review+
Attachment #9018875 - Flags: approval-comm-esr60?
See Also: → 1501093
Comment on attachment 9018874 [details] [diff] [review]
1500747-mozconfig-extensions.patch

Review of attachment 9018874 [details] [diff] [review]:
-----------------------------------------------------------------

r+ w/ query answered..

::: suite/app.mozbuild
@@ +14,5 @@
> +    DIRS += ['/extensions/irc']
> +
> +if CONFIG['MOZ_DOMINSPECTOR']:
> +    DIRS += ['/extensions/inspector']
> +

is MOZ_DEBUGQA needed here? or is that done somewhere else?
Comment on attachment 9018874 [details] [diff] [review]
1500747-mozconfig-extensions.patch

Review of attachment 9018874 [details] [diff] [review]:
-----------------------------------------------------------------

I could've sworn I put a r+.
Attachment #9018874 - Flags: review?(ewong) → review+
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/b44fb89ce5da
Allow overriding extension building defaults in SeaMonkey via mozconfig. r=ewong
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → Future
Comment on attachment 9018874 [details] [diff] [review]
1500747-mozconfig-extensions.patch

a=me
Attachment #9018874 - Flags: approval-comm-esr60? → approval-comm-esr60+
You need to log in before you can comment on or make changes to this bug.