1500750 - OscillatorNode's AudioScheduledSourceNode.start() does not throw a RangeError

Status: REOPENED

(Core :: Web Audio, defect, P3)

Description

[chrisguttandin]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.67 Safari/537.36

Steps to reproduce:

const audioContext = new AudioContext();

const audioBufferSourceNode = new AudioBufferSourceNode(audioContext);

try {
    audioBufferSourceNode.start(-1);
} catch (err) {
    console.log(err instanceof RangeError);
}

const constantSourceNode = new ConstantSourceNode(audioContext);

try {
    constantSourceNode.start(-1);
} catch (err) {
    console.log(err instanceof RangeError);
}

const oscillatorNode = new OscillatorNode(audioContext);

try {
    oscillatorNode.start(-1);
} catch (err) {
    console.log(err instanceof RangeError);
}


Actual results:

All calls to start of an AudioScheduledSourceNode with a negative value throw a DOMException. The same is true for calls to stop with a negative value.


Expected results:

Calls with a negative value should throw a RangeError.

https://webaudio.github.io/web-audio-api/#dom-audioscheduledsourcenode-start
https://webaudio.github.io/web-audio-api/#dom-audioscheduledsourcenode-stop

Comment 1

[Karl Tomlinson (:karlt)]

This should be fixed in 63 by https://hg.mozilla.org/mozilla-central/rev/c6efa2d9a32006f3d676dca81048ac5e30a4a4a4#l3.12

Comment 2

[chrisguttandin]

Sorry for filing a duplicate bug. I apparently searched for the wrong keywords.

I can confirm that the AudioBufferSourceNode and the ConstantSourceNode behave correctly in Firefox 64 but the OscillatorNode is still throwing a DOMException. The OscillatorNode is not mentioned in the other bug's description which is probably the reason why.

Should I report this on the thread of the other bug?

Comment 3

[Karl Tomlinson (:karlt)]

No harm in filing a duplicate bug, but sorry that I didn't check OscillatorNode.  Thank /you/ for doing so.

I'll reopen this to track OscillatorNode.  Mozilla's bug reports track symptoms until a patch is applied, after which the bug tracks the patch.  We need a new report (this one) if the same symptoms remain after the patch.

Comment 4

[laetitianp022]

Attachment: Bug 1500750 - Throw a RangeError instead of a NotSupportedError in OscillatorNode.start, to match the spec. r?padenot

Comment 5

[nazarcf]

Attachment: Bug 1500750 - Throws a RangeError for negative start time, grouped audioscheduled related tests in the-audioscheduledsource-interface. r?padenot

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:padenot, could you have a look please?
For more information, please visit auto_nag documentation.