1500782 - Should we remove the support for CanvasRenderingContext2D in CreateImageBitmap?

Status: REOPENED

(Core :: Graphics: Canvas2D, task, P2)

Description

[Andrea Marchesini [:baku]]

This is not in the spec and it's not supported by other browsers.

Comment 1

[Andrea Marchesini [:baku]]

Attachment: image5.patch

Comment 2

[Andrew Osmond [:aosmond] (he/him)]

Comment on attachment 9018897 [details] [diff] [review]
image5.patch

Review of attachment 9018897 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/webidl/ImageBitmap.webidl
@@ -18,5 @@
>           ImageBitmap) CanvasImageSourceExcludedSVG;
>  
>  typedef (CanvasImageSourceExcludedSVG or
>           Blob or
> -         CanvasRenderingContext2D or // This is out of spec.

It looks like this was not pref'd off, so we are currently shipping this. We probably need an intent to unship? Do we know how much this is used, if at all?

Comment 3

[Andrew Osmond [:aosmond] (he/him)]

Comment on attachment 9018897 [details] [diff] [review]
image5.patch

Clearing myself of the review until we get the usage numbers from bug 1502304.

Comment 4

[Angus Sawyer]

Should this be removed now? Three years old and causes a wpt failure.

Comment 5

[Anne (:annevk)]

Can you clarify why you marked this as invalid? https://searchfox.org/mozilla-central/source/dom/webidl/ImageBitmap.webidl#15 suggests this is still valid (at least partially).