Closed Bug 1500788 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 13642 - Remove unused `channel` argument in `Firefox.version`

Categories

(Testing :: web-platform-tests, enhancement, P4)

enhancement

Tracking

(firefox65 fixed)

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 13642 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/13642
Details from upstream follow.

Philip Jägenstedt <philip@foolip.org> wrote:
>  Remove unused `channel` argument in `Firefox.version`
>  
>  The only call site is in at the end of `setup_wptrunner` (run.py) where
>  no `channel` argument is passed. At that point, `setup_kwargs` has
>  already been called, which guarantees that `kwargs["binary"]` is set, so
>  even the fallback `self.find_binary(channel)` (where `channel` would be
>  `None`) is dead code.
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8cdccc84d34f
[wpt PR 13642] - Remove unused `channel` argument in `Firefox.version`, a=testonly
Result changes from PR not available.
https://hg.mozilla.org/mozilla-central/rev/8cdccc84d34f
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.