1500788 - [wpt-sync] Sync PR 13642 - Remove unused `channel` argument in `Firefox.version`

Status: RESOLVED FIXED

(Testing :: web-platform-tests, enhancement, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 13642 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/13642
Details from upstream follow.

Philip Jägenstedt <[e-mail]> wrote:
>  Remove unused `channel` argument in `Firefox.version`
>  
>  The only call site is in at the end of `setup_wptrunner` (run.py) where
>  no `channel` argument is passed. At that point, `setup_kwargs` has
>  already been called, which guarantees that `kwargs["binary"]` is set, so
>  even the fallback `self.find_binary(channel)` (where `channel` would be
>  `None`) is dead code.

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=e779b88fd4aa9a26d460429e5ed3580568caf767

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=96da24a421523228eea7caa08f5f1b4a5a3ca830

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8cdccc84d34f
[wpt PR 13642] - Remove unused `channel` argument in `Firefox.version`, a=testonly

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Result changes from PR not available.

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/8cdccc84d34f