Closed
Bug 1500821
Opened 6 years ago
Closed 6 years ago
Call RecordFrame() only for non-empty frame at NotifyDidRender()
Categories
(Core :: Graphics: WebRender, defect)
Core
Graphics: WebRender
Tracking
()
RESOLVED
FIXED
mozilla65
| Tracking | Status | |
|---|---|---|
| firefox65 | --- | fixed |
People
(Reporter: sotaro, Assigned: sotaro)
References
Details
Attachments
(1 file)
|
1.50 KB,
patch
|
mattwoodrow
:
review+
|
Details | Diff | Splinter Review |
Since Bug 1461239 fix, FrameRecorder::RecordFrame() is also called during non-empty frame(skip frame rendering) at NotifyDidRender(). https://dxr.mozilla.org/mozilla-central/source/gfx/webrender_bindings/RenderThread.cpp#345 But the RecordFrame() should not be called for non-empty frame for not to change what Talos measures like LayerManagerComposite. https://dxr.mozilla.org/mozilla-central/source/gfx/layers/mlgpu/LayerManagerMLGPU.cpp#328 https://dxr.mozilla.org/mozilla-central/source/gfx/layers/composite/LayerManagerComposite.cpp#1012
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → sotaro.ikeda.g
|
|
Assignee | |
Comment 1•6 years ago
|
||
|
|
Assignee | |
Updated•6 years ago
|
Attachment #9018940 -
Flags: review?(matt.woodrow)
|
||
Updated•6 years ago
|
Attachment #9018940 -
Flags: review?(matt.woodrow) → review+
Pushed by sikeda@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/bd15c0cbc18a Call RecordFrame() only for non-empty frame at NotifyDidRender() r=mattwoodrow
|
||
Comment 3•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/bd15c0cbc18a
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in
before you can comment on or make changes to this bug.
Description
•