Call RecordFrame() only for non-empty frame at NotifyDidRender()

RESOLVED FIXED in Firefox 65

Status

()

defect
RESOLVED FIXED
10 months ago
10 months ago

People

(Reporter: sotaro, Assigned: sotaro)

Tracking

unspecified
mozilla65
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox65 fixed)

Details

Attachments

(1 attachment)

Since Bug 1461239 fix, FrameRecorder::RecordFrame() is also called during non-empty frame(skip frame rendering) at NotifyDidRender().
 https://dxr.mozilla.org/mozilla-central/source/gfx/webrender_bindings/RenderThread.cpp#345

But the RecordFrame() should not be called for non-empty frame for not to change what Talos measures like LayerManagerComposite.

 https://dxr.mozilla.org/mozilla-central/source/gfx/layers/mlgpu/LayerManagerMLGPU.cpp#328
 https://dxr.mozilla.org/mozilla-central/source/gfx/layers/composite/LayerManagerComposite.cpp#1012
Blocks: 1461239
Assignee: nobody → sotaro.ikeda.g
Attachment #9018940 - Flags: review?(matt.woodrow)
Attachment #9018940 - Flags: review?(matt.woodrow) → review+
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bd15c0cbc18a
Call RecordFrame() only for non-empty frame at NotifyDidRender() r=mattwoodrow
https://hg.mozilla.org/mozilla-central/rev/bd15c0cbc18a
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.