1500836 - [BinAST] delete operator on an argument cannot find binding

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P3)

Description

[Tooru Fujisawa [:arai]]

encoded from
https://searchfox.org/mozilla-central/source/js/src/jit-test/tests/parser/bug-888002-2.js

tested on m-i 716178d41d26

Configure flags: --enable-warnings-as-errors --disable-optimize --enable-debug

Runtime flag: -B del-arg.binjs

Actual result: Error: Assertion failed: got true, expected false


the problematic part is

  (function (x) {
  ...
      assertEq(delete x, false);
  }());

that `delete x` fails because it cannot find the binding name in js::DeleteNameOperation

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: del-arg.binjs

Comment 2

[Tooru Fujisawa [:arai]]

delete with name operand should call setBindingsAccessedDynamically

Comment 3

[Tooru Fujisawa [:arai]]

in order to throw the same error as regular parser on "delete name" in strict mode,
depends bug 1502280.

Comment 4

[Tooru Fujisawa [:arai]]

Attachment: Call setBindingsAccessedDynamically if delete with name operand appears in BinAST.

based on bug 1502792 patch.

Comment 5

[David Teller [:Yoric] - still alive but not very active]

Comment on attachment 9023160 [details] [diff] [review]
Call setBindingsAccessedDynamically if delete with name operand appears in BinAST.

Review of attachment 9023160 [details] [diff] [review]:
-----------------------------------------------------------------

Ouch, I had entirely forgotten that we can do that.

JS has a few scary corners :)

Comment 6

[Tooru Fujisawa [:arai]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a9f1fba8641a368ffdbea3b7daf62c3a1a6a4152
Bug 1500836 - Call setBindingsAccessedDynamically if delete with name operand appears in BinAST. r=Yoric

Comment 7

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/a9f1fba8641a