1500881 - WindowEventManager uses deprecated EventManager constructor

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: Extensions API, defect)

Description

[[e-mail]]

Comment on attachment 8988432 [details] [diff] [review]
1455471-webext-windowstabs-2.diff

>+global.WindowEventManager = class extends EventManager {
>+  constructor(context, name, event, listener) {
>+    super(context, name, fire => {
ESR60 syntax (wrong for this trunk patch!)

>+    super({
>+      context,
>+      name: "tabs.onUpdated",
>+      register,
>+    });
Correct trunk syntax.

Comment 1

[Jorg K (CEST = GMT+2)]

Geoff, can you please take care of this.

Neil, thanks for filing!

Comment 2

[Geoff Lankow (:darktrojan)]

Attachment: 1500881-event-manager-1.diff

I've also converted both our subclasses to the same format.

Comment 3

[Jorg K (CEST = GMT+2)]

Comment on attachment 9019173 [details] [diff] [review]
1500881-event-manager-1.diff

All I can do here is pattern matching. Let's get a qualified review. Or perhaps ask Neil who detected it.

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 9019173 [details] [diff] [review]
1500881-event-manager-1.diff

Review of attachment 9019173 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM thx! r=mkmelin

::: mail/components/extensions/parent/ext-mail.js
@@ +185,5 @@
> +  constructor({ context, name, event, listener }) {
> +    super({
> +      context,
> +      name,
> +      listener: fire => {

nit: I think it's clearer for readability to put parenthesis around (fire)

Comment 5

[Geoff Lankow (:darktrojan)]

Attachment: 1500881-event-manager-2.diff

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/02352ad526d3
Use new EventManager constructor. r=mkmelin

Comment 7

[Jorg K (CEST = GMT+2)]

Comment on attachment 9019289 [details] [diff] [review]
1500881-event-manager-2.diff

I guess this needs beta uplift. What exactly didn't work? Or would that have only be noticeable with a WebExtension?

Comment 8

[Jorg K (CEST = GMT+2)]

Beta (TB 64):
https://hg.mozilla.org/releases/comm-beta/rev/b84fdd866fb7