1500933 - Track Changes - avoid emitting events from the server if there's no listener on the client

Status: RESOLVED FIXED

(DevTools :: Inspector, enhancement, P2)

Description

[Razvan Caliman [:rcaliman]]

The ChangesActor collects information on the server and emits events with data about the changes over the protocol so the client can aggregate and display the results.

Unless the Changes panel is visible, these events have no listener and are therefore needlessly passed over the server-client divide.

When the Changes panel is instantiated (client), it starts listening for events. Additionally, it makes a request to get all changes collected up to that point in that session. We can't know server-side when something subscribes to events, but we can use this initial request for all changes as a hint that there is an interested consumer so we can begin emitting events.

Comment 1

[Brad Werth [:bradwerth]]

Attachment: Bug 1500933 Part 1: Define a ChangesActor no-op method for use by the client to instantiate the actor. r?rcaliman!

Comment 2

[Brad Werth [:bradwerth]]

Attachment: Bug 1500933 Part 2: Avoid sending events from ChangesActor until we've verified there's a listener. r?rcaliman!

Depends on D10119

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8d9adc3af751
Part 1: Define a ChangesActor no-op method for use by the client to instantiate the actor. r=rcaliman
https://hg.mozilla.org/integration/autoland/rev/93012cb45617
Part 2: Avoid sending events from ChangesActor until we've verified there's a listener. r=rcaliman

Comment 4

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/8d9adc3af751
https://hg.mozilla.org/mozilla-central/rev/93012cb45617