Closed Bug 1500936 Opened Last year Closed Last year

Remove comma-dangle override from inspector eslintrc

Categories

(DevTools :: Inspector, enhancement, P3)

enhancement

Tracking

(firefox65 fixed)

RESOLVED FIXED
Firefox 65
Tracking Status
firefox65 --- fixed

People

(Reporter: jdescottes, Assigned: jdescottes)

Details

Attachments

(2 files)

The following eslint rule:

    // The webpack bundle does not support trailing commas in functions, so disabled it
    // explicitly with linting here.
    "comma-dangle": ["error", {
      "arrays": "ignore",
      "objects": "ignore",
      "imports": "ignore",
      "exports": "ignore",
      "functions": "never",
    }]

was added when the inspector was built using webpack and should be removed now that comma-dangle has been enabled for devtools/ in https://bugzilla.mozilla.org/show_bug.cgi?id=1486741
Summary: Remove comm-dangle override from inspector eslintrc → Remove comma-dangle override from inspector eslintrc
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/924b484fa4df
Remove comma-dangle override from devtools/client/inspector;r=Standard8
https://hg.mozilla.org/integration/autoland/rev/98cfc4f7de93
Run eslint --fix on devtools/client/inspector for comma-dangle;r=Standard8
https://hg.mozilla.org/mozilla-central/rev/924b484fa4df
https://hg.mozilla.org/mozilla-central/rev/98cfc4f7de93
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
You need to log in before you can comment on or make changes to this bug.