Closed Bug 1500959 Opened Last year Closed Last year

Fix todo_is in browser_visibleTabs_tabPreview.js

Categories

(Firefox :: Tabbed Browser, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 65
Tracking Status
firefox65 --- fixed

People

(Reporter: jdescottes, Assigned: dao)

References

Details

Attachments

(1 file)

Bug 1499096 will switch a call to ok() to is(). Most likely intended by the author of the test, but the assert fails at the moment:

  todo_is(ctrlTab.tabList.length, 1, "Show 1 tab in tab preview");
Component: General → Marionette
Product: Firefox → Testing
Component: Marionette → General
Product: Testing → Firefox
Component: General → Tabbed Browser
Priority: P3 → --
Severity: enhancement → normal
Priority: -- → P3
(In reply to Julian Descottes [:jdescottes][:julian] from comment #0)
> Bug 1499096 will switch a call to ok() to is(). Most likely intended by the
> author of the test, but the assert fails at the moment:
> 
>   todo_is(ctrlTab.tabList.length, 1, "Show 1 tab in tab preview");

This check doesn't seem useful in the first place because the panel isn't supposed to show at that point.
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/88351e371a8b
Clean up browser_visibleTabs_tabPreview.js. r=Standard8
https://hg.mozilla.org/mozilla-central/rev/88351e371a8b
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
You need to log in before you can comment on or make changes to this bug.