Open Bug 1500960 Opened 1 year ago Updated 1 year ago

Enable commented out assert in devtools/server/tests/mochitest/test_inspector-retain.html

Categories

(DevTools :: General, enhancement)

enhancement
Not set

Tracking

(Not tracked)

People

(Reporter: jdescottes, Unassigned)

References

Details

Bug 1499096 will switch a call to ok() to is(). Most likely intended by the author of the test, but the assert fails at the moment:

  // ok(err, "noSuchActor", "Should have lost the race.");

The assert was commented out because it is not clear what the compared value should be.
Component: General → Marionette
Product: Firefox → Testing
Component: Marionette → General
Product: Testing → Firefox
Hi Andreas,

Marionette is the common component for the automated tests. Is it not correct? If not, isn't there a more appropriate component for the implementation of automated test?
Flags: needinfo?(ato)
Testing :: Marionette is a component for tests backed by the
Marionette [1] remote protocol, but not for _any_ tests.
devtools/server/tests/mochitest/test_inspector-retain.html is a
mochitest, but that also does not imply that it is a bug related
to the mochitest harness itself.

I think this is referring to fixing up a unit test in devtools, so
the appropriate component for this bug is likely going to be somewhere
in devtools.

  [1] https://firefox-source-docs.mozilla.org/testing/marionette/marionette/Intro.html
Flags: needinfo?(ato)
Priority: P3 → --
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.