Closed Bug 1500961 Opened 6 years ago Closed 3 years ago

Enable commented out assert in dom/base/test/test_sendQueryContentAndSelectionSetEvent.html

Categories

(Core :: DOM: UI Events & Focus Handling, defect, P3)

Product:
Core
Component:
DOM: UI Events & Focus Handling
Type:
defect

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: jdescottes, Assigned: masayuki)

References

(Depends on 1 open bug)

Details

(Keywords: inputmethod) 

Bug 1499096 will switch a call to ok() to is(). Most likely intended by the author of the test, but the assert fails at the moment:

  // is(textRect.width, width.value + width2.value,
  //     "sendQueryContentEvent(QUERY_TEXT_RECT_ARRAY) should return same width that QUERY_TEXT_RECT is returned for offset 1 and 2");

The assert was commented out because it is sometimes passes and sometimes fails depending on the platform (can't use is() or todo_is().
Component: General → Marionette
Product: Firefox → Testing
Component: Marionette → General
Product: Testing → Firefox
Component: General → DOM
Priority: P3 → --
Product: Firefox → Core
Looks like Makoto wrote this over in bug 1203871.
Flags: needinfo?(m_kato)
Priority: -- → P3
Assignee: nobody → m_kato
Flags: needinfo?(m_kato)
Component: DOM → DOM: Core & HTML

Well, I found this at testing my patch for bug 1678553. It should use isfuzzy since it may cause platform/environment specific failure due to rounding error. I'll fix this in the patch.

Assignee: m_kato → masayuki
Status: NEW → ASSIGNED
Type: enhancement → defect
Component: DOM: Core & HTML → DOM: UI Events & Focus Handling
OS: Unspecified → All
Hardware: Unspecified → All

Fixed by part.13 of bug 1678553.

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.