Closed Bug 1500975 Opened Last year Closed Last year

Xpcshell harness not setting gmp-manager.updateEnabled properly

Categories

(Testing :: XPCShell Harness, enhancement, P3)

Version 3
enhancement

Tracking

(firefox65 fixed)

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: ahal, Assigned: aswan)

References

Details

Attachments

(1 file, 1 obsolete file)

I noticed this while doing some pref refactoring in the xpcshell harness. Xpcshell uses "setCharPref" to set the 'media.gmp-manager.updateEnabled' pref:
https://searchfox.org/mozilla-central/source/testing/xpcshell/head.js#1490

However, this should be a bool pref:
https://searchfox.org/mozilla-central/rev/fcfb479e6ff63aea017d063faa17877ff750b4e5/toolkit/mozapps/extensions/internal/ProductAddonChecker.jsm#229

If I make the switch to "bool", then toolkit/modules/tests/xpcshell/test_GMPInstallManager.js starts failing. So this leads me to believe that the pref is not actually being applied.

We should change the pref to a bool and fix the test (the test can re-enable the pref itself if it really needs it).
Priority: -- → P3
Blocks: 1451532
Attachment #9024927 - Attachment is obsolete: true
Andrew, the test failure in test_GMPInstallManager.js was due to the test trying to do updates (ie, it needs that pref to be false).  I have some other changes that are triggering unrelated test failures since they end up triggering GMP updates which do non-local network connections but I think the fix is pretty simple (see attached patch)
Assignee: nobody → aswan
Status: NEW → ASSIGNED
See Also: → 1507255
https://hg.mozilla.org/mozilla-central/rev/3f5cc25fc41e
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.