Closed Bug 1500975 Opened Last year Closed Last year
Xpcshell harness not setting gmp-manager
.update Enabled properly
47 bytes, text/x-phabricator-request
|Details | Review|
I noticed this while doing some pref refactoring in the xpcshell harness. Xpcshell uses "setCharPref" to set the 'media.gmp-manager.updateEnabled' pref: https://searchfox.org/mozilla-central/source/testing/xpcshell/head.js#1490 However, this should be a bool pref: https://searchfox.org/mozilla-central/rev/fcfb479e6ff63aea017d063faa17877ff750b4e5/toolkit/mozapps/extensions/internal/ProductAddonChecker.jsm#229 If I make the switch to "bool", then toolkit/modules/tests/xpcshell/test_GMPInstallManager.js starts failing. So this leads me to believe that the pref is not actually being applied. We should change the pref to a bool and fix the test (the test can re-enable the pref itself if it really needs it).
Andrew, the test failure in test_GMPInstallManager.js was due to the test trying to do updates (ie, it needs that pref to be false). I have some other changes that are triggering unrelated test failures since they end up triggering GMP updates which do non-local network connections but I think the fix is pretty simple (see attached patch)
Assignee: nobody → aswan
Status: NEW → ASSIGNED
https://hg.mozilla.org/integration/mozilla-inbound/rev/3f5cc25fc41e5de6bb3b65fafb3c635a45372c77 Bug 1500975 Disable GMP updates during xpcshell tests r=ahal
You need to log in before you can comment on or make changes to this bug.