1500987 - Elevate the new debugger one directory

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement, P3)

Description

[David Walsh :davidwalsh]

Once the old tests are moved to shared/, we should elevate the debugger one directory level so that it lives right in debugger, not debugger/new

Comment 1

[David Walsh :davidwalsh]

Attachment: 1500987-1.patch

This PR removes the old moz.build so that a move of the same file in the /new directory wont break history.

Comment 2

[David Walsh :davidwalsh]

Attachment: 1500987-2.patch

This is the large file move and changing of references to the new location. (i.e. remove /new from a bunch of strings.

Comment 3

[Alexandre Poirot [:ochameau]]

Comment on attachment 9038896 [details] [diff] [review]
1500987-2.patch

Review of attachment 9038896 [details] [diff] [review]:
-----------------------------------------------------------------

You are missing the following ocurrences:
https://searchfox.org/mozilla-central/source/devtools/client/shared/components/SmartTrace.css#138
https://searchfox.org/mozilla-central/source/toolkit/content/license.html#2806
(there is more than one occurence in this html file)
https://searchfox.org/mozilla-central/source/testing/talos/talos/tests/devtools/addon/content/tests/debugger/debugger-helpers.js#12

Otherwise, I had to manually move reload.svg and FrameIndent.js, but I imagine that's a rebase issue.
Sorry about the delay in reviewing this patch, hopefully the rebase will be trivial for you.

Thanks a lot for finishing the move!!

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:davidwalsh, could you have a look please?

Comment 5

[David Walsh :davidwalsh]

Unfortunately these require a massive rebase which I hope to get to soon.

Comment 6

[David Walsh :davidwalsh]

Attachment: Bug 1500987 - Remove debugger's old moz.build file r=jlast

Comment 7

[David Walsh :davidwalsh]

Attachment: Bug 1500987 - Remove debugger's old moz.build file r=jlast

Comment 8

[David Walsh :davidwalsh]

Attachment: 1500987-1.patch

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/21e7aa527584
Elevate the new debugger one directory. r=jlast

Comment 10

[Andreea Pavel [:apavel]]

Backed out for debugger, clipboard and devtools failures

Push with failures

Failure logs: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=testfailed%2Cbusted%2Cexception&group_state=expanded&selectedJob=238884329&revision=21e7aa52758441a6601b9e2f9a9ca6382cc26c1d

Debugger: https://treeherder.mozilla.org/logviewer.html#?job_id=238884329&repo=mozilla-inbound
clipboard: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=238891061&repo=mozilla-inbound&lineNumber=9868
devtools: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=testfailed%2Cbusted%2Cexception&group_state=expanded&selectedJob=238888310&revision=21e7aa52758441a6601b9e2f9a9ca6382cc26c1d

Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/db09a6f1febb8564b1a03bf774cf761310fd227a

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ca42d5764b08
Elevate the new debugger one directory. r=jlast

Comment 12

[Noemi Erli[:noemi_erli]]

Backed out changeset ca42d5764b08 (Bug 1500987) for failures in browser_dbg_worker-console-04.js

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=pending%2Crunning%2Ctestfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=239092201&searchStr=16df33d45d5cf1d2d03d743c61e8127def40aea9&revision=ca42d5764b089097bd34b7f6fef770bc46c2d675

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=239092201&repo=mozilla-inbound&lineNumber=3576

Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/86b54cfca31f806cc151bddc96d228aafb71f988

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e9408a26af67
Elevate the new debugger one directory. r=jlast

Comment 14

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/e9408a26af67